Skip to content

Update MAINTAINERS.md and CODEOWNERS #18462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
deepthi merged 3 commits into from
Jul 18, 2025
Merged

Update MAINTAINERS.md and CODEOWNERS #18462

deepthi merged 3 commits into from
Jul 18, 2025

Conversation

@deepthi
Copy link
Collaborator

@deepthi deepthi commented Jul 18, 2025 •
edited
Loading

Move @deepthi to emeritus.

Description

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@deepthi
Update MAINTAINERS.md
fa07825 
move deepthi to emeritus

Signed-off-by: Deepthi Sigireddi <[email protected]>
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Jul 18, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jul 18, 2025
@github-actions github-actions bot added this to the v23.0.0 milestone Jul 18, 2025
@deepthi deepthi added Type: Documentation Component: Governance and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jul 18, 2025
@deepthi
Update CODEOWNERS
d09ca4a 
Signed-off-by: Deepthi Sigireddi <[email protected]>
@deepthi
Update CODEOWNERS
2f22919 
Signed-off-by: Deepthi Sigireddi <[email protected]>
@deepthi deepthi changed the title Update MAINTAINERS.md Update MAINTAINERS.md and CODEOWNERS Jul 18, 2025
@deepthi deepthi mentioned this pull request Jul 18, 2025
Merged
3 tasks
mattlord
mattlord approved these changes Jul 18, 2025
View reviewed changes
Copy link
Member

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢 Thank you for everything you've done for Vitess over the years, @deepthi ! The project would not be where it's at without your immeasurable contributions. ❤️

shlomi-noach
shlomi-noach reviewed Jul 18, 2025
View reviewed changes
Copy link
Contributor

@shlomi-noach shlomi-noach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Boo!

@deepthi deepthi merged commit abf1f77 into main Jul 18, 2025
201 checks passed
@deepthi deepthi deleted the deepthi-patch-1 branch July 18, 2025 20:44
morgo added a commit to morgo/vitess that referenced this pull request Jul 21, 2025
@morgo
Merge remote-tracking branch 'origin/master' into mysql-topo
f49a6c2 
* origin/master:
  bugfix: Fix impossible query for UNION (vitessio#18463)
  fix topo use in local_example (vitessio#18357)
  fix: update go-upgrade tool to check patch number (vitessio#18252) (vitessio#18402)
  Update MAINTAINERS.md and CODEOWNERS (vitessio#18462)
  Add logging to binlog watcher actions (vitessio#18264)
  `schemadiff`: `RelatedForeignKeyTables()` (vitessio#18195)
  `vtorc`: allow recoveries to be disabled from startup (vitessio#18005)
  Fix `vttablet` not being marked as not serving when MySQL stalls (vitessio#17883)
  make xtrabackup ShouldDrainForBackup configurable (vitessio#18431)
  Reset in-memory sequence info on vttablet on UpdateSequenceTables request (vitessio#18415)
  Fix watcher storm during topo outages (vitessio#18434)
  Online DDL: resume vreplication after cut-over/RENAME failure (vitessio#18428)
  Online DDL cutover enhancements (vitessio#18423)
  VStreamer: change in filter logic (vitessio#18319)
  Online DDL metrics: `OnlineDDLStaleMigrationMinutes` (vitessio#18417)

Signed-off-by: Morgan Tocker <[email protected]>
morgo added a commit to morgo/vitess that referenced this pull request Jul 29, 2025
@morgo
Merge remote-tracking branch 'origin/master' into mtocker-virtual-sha…
ea7e594 
…rds-new2

* origin/master:
  bugfix: Fix impossible query for UNION (vitessio#18463)
  fix topo use in local_example (vitessio#18357)
  fix: update go-upgrade tool to check patch number (vitessio#18252) (vitessio#18402)
  Update MAINTAINERS.md and CODEOWNERS (vitessio#18462)
  Add logging to binlog watcher actions (vitessio#18264)
  `schemadiff`: `RelatedForeignKeyTables()` (vitessio#18195)
  `vtorc`: allow recoveries to be disabled from startup (vitessio#18005)
  Fix `vttablet` not being marked as not serving when MySQL stalls (vitessio#17883)
  make xtrabackup ShouldDrainForBackup configurable (vitessio#18431)

Signed-off-by: Morgan Tocker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattlord mattlord mattlord approved these changes

@shlomi-noach shlomi-noach shlomi-noach approved these changes

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner

Assignees

No one assigned

Labels

Component: Governance Type: Documentation

Projects

None yet

Milestone

v23.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@deepthi @mattlord @shlomi-noach