Skip to content

Conversation

@timvaillancourt
Copy link
Contributor

@timvaillancourt timvaillancourt commented Mar 22, 2025

Description

This PR allows recoveries in VTOrc to be disabled from startup time. This is already possible to do via the HTTP API on a per-instance basis after the process has started, but there's no way to ensure it's done immediately at startup

The same DisableRecovery() function as the HTTP API is used to do this at startup when the new flag --allow-recovery is set to false

Related Issue(s)

Resolves #18007

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@timvaillancourt timvaillancourt added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: VTorc Vitess Orchestrator integration labels Mar 22, 2025
@timvaillancourt timvaillancourt self-assigned this Mar 22, 2025
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Mar 22, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Mar 22, 2025
@timvaillancourt timvaillancourt changed the title vtorc: allow recoveries to be disabled vtorc: allow recoveries to be disabled from startup Mar 22, 2025
@timvaillancourt timvaillancourt removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Mar 22, 2025
@github-actions github-actions bot added this to the v22.0.0 milestone Mar 22, 2025
Signed-off-by: Tim Vaillancourt <[email protected]>
@timvaillancourt timvaillancourt marked this pull request as ready for review March 22, 2025 21:31
@timvaillancourt timvaillancourt removed the NeedsIssue A linked issue is missing for this Pull Request label Mar 23, 2025
Signed-off-by: Tim Vaillancourt <[email protected]>
@frouioui frouioui modified the milestones: v22.0.0, v23.0.0 Apr 1, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2025

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

  • Push additional commits to the associated branch.
  • Remove the stale label.
  • Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

@github-actions github-actions bot added the Stale Marks PRs as stale after a period of inactivity, which are then closed after a grace period. label May 2, 2025
@timvaillancourt timvaillancourt removed the Stale Marks PRs as stale after a period of inactivity, which are then closed after a grace period. label May 3, 2025
Copy link
Contributor

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2025

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

  • Push additional commits to the associated branch.
  • Remove the stale label.
  • Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

@github-actions github-actions bot added the Stale Marks PRs as stale after a period of inactivity, which are then closed after a grace period. label Jun 7, 2025
@timvaillancourt timvaillancourt removed the Stale Marks PRs as stale after a period of inactivity, which are then closed after a grace period. label Jun 7, 2025
Signed-off-by: Tim Vaillancourt <[email protected]>
@timvaillancourt timvaillancourt requested a review from deepthi June 30, 2025 20:42
@deepthi
Copy link
Collaborator

deepthi commented Jun 30, 2025

Is there a dynamic flag test for vtorc? Worth adding this to that?

@codecov
Copy link

codecov bot commented Jun 30, 2025

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 67.50%. Comparing base (dc63684) to head (ddb147b).
Report is 153 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/vtorc/config/config.go 0.00% 4 Missing ⚠️
go/vt/vtorc/logic/vtorc.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18005      +/-   ##
==========================================
- Coverage   67.57%   67.50%   -0.08%     
==========================================
  Files        1598     1607       +9     
  Lines      260044   262694    +2650     
==========================================
+ Hits       175735   177331    +1596     
- Misses      84309    85363    +1054     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@harshit-gangal harshit-gangal merged commit 256ca78 into vitessio:main Jul 16, 2025
104 of 108 checks passed
@timvaillancourt timvaillancourt deleted the vtorc-allow-recovery branch July 16, 2025 23:32
morgo added a commit to morgo/vitess that referenced this pull request Jul 21, 2025
* origin/master:
  bugfix: Fix impossible query for UNION (vitessio#18463)
  fix topo use in local_example (vitessio#18357)
  fix: update go-upgrade tool to check patch number (vitessio#18252) (vitessio#18402)
  Update MAINTAINERS.md and CODEOWNERS (vitessio#18462)
  Add logging to binlog watcher actions (vitessio#18264)
  `schemadiff`: `RelatedForeignKeyTables()` (vitessio#18195)
  `vtorc`: allow recoveries to be disabled from startup (vitessio#18005)
  Fix `vttablet` not being marked as not serving when MySQL stalls (vitessio#17883)
  make xtrabackup ShouldDrainForBackup configurable (vitessio#18431)
  Reset in-memory sequence info on vttablet on UpdateSequenceTables request (vitessio#18415)
  Fix watcher storm during topo outages (vitessio#18434)
  Online DDL: resume vreplication after cut-over/RENAME failure (vitessio#18428)
  Online DDL cutover enhancements (vitessio#18423)
  VStreamer: change in filter logic (vitessio#18319)
  Online DDL metrics: `OnlineDDLStaleMigrationMinutes` (vitessio#18417)

Signed-off-by: Morgan Tocker <[email protected]>
morgo added a commit to morgo/vitess that referenced this pull request Jul 29, 2025
…rds-new2

* origin/master:
  bugfix: Fix impossible query for UNION (vitessio#18463)
  fix topo use in local_example (vitessio#18357)
  fix: update go-upgrade tool to check patch number (vitessio#18252) (vitessio#18402)
  Update MAINTAINERS.md and CODEOWNERS (vitessio#18462)
  Add logging to binlog watcher actions (vitessio#18264)
  `schemadiff`: `RelatedForeignKeyTables()` (vitessio#18195)
  `vtorc`: allow recoveries to be disabled from startup (vitessio#18005)
  Fix `vttablet` not being marked as not serving when MySQL stalls (vitessio#17883)
  make xtrabackup ShouldDrainForBackup configurable (vitessio#18431)

Signed-off-by: Morgan Tocker <[email protected]>
timvaillancourt added a commit to slackhq/vitess that referenced this pull request Aug 19, 2025
timvaillancourt added a commit to slackhq/vitess that referenced this pull request Aug 19, 2025
timvaillancourt added a commit to slackhq/vitess that referenced this pull request Aug 19, 2025
timvaillancourt added a commit to slackhq/vitess that referenced this pull request Aug 22, 2025
tanjinx pushed a commit to slackhq/vitess that referenced this pull request Oct 24, 2025
tanjinx added a commit to slackhq/vitess that referenced this pull request Nov 4, 2025
tanjinx added a commit to slackhq/vitess that referenced this pull request Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: VTorc Vitess Orchestrator integration Type: Enhancement Logical improvement (somewhere between a bug and feature)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: allow VTOrc to start with recoveries disabled

5 participants