-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Online DDL metrics: OnlineDDLStaleMigrationMinutes
#18417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
shlomi-noach
merged 2 commits into
vitessio:main
from
planetscale:onlineddl-report-vrepl-liveness
Jul 8, 2025
Merged
Online DDL metrics: OnlineDDLStaleMigrationMinutes
#18417
shlomi-noach
merged 2 commits into
vitessio:main
from
planetscale:onlineddl-report-vrepl-liveness
Jul 8, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18417 +/- ##
==========================================
- Coverage 67.51% 67.49% -0.02%
==========================================
Files 1607 1607
Lines 262687 262741 +54
==========================================
- Hits 177340 177327 -13
- Misses 85347 85414 +67 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rohit-nayak-ps
approved these changes
Jul 6, 2025
notfelineit
approved these changes
Jul 7, 2025
morgo
added a commit
to morgo/vitess
that referenced
this pull request
Jul 21, 2025
* origin/master: bugfix: Fix impossible query for UNION (vitessio#18463) fix topo use in local_example (vitessio#18357) fix: update go-upgrade tool to check patch number (vitessio#18252) (vitessio#18402) Update MAINTAINERS.md and CODEOWNERS (vitessio#18462) Add logging to binlog watcher actions (vitessio#18264) `schemadiff`: `RelatedForeignKeyTables()` (vitessio#18195) `vtorc`: allow recoveries to be disabled from startup (vitessio#18005) Fix `vttablet` not being marked as not serving when MySQL stalls (vitessio#17883) make xtrabackup ShouldDrainForBackup configurable (vitessio#18431) Reset in-memory sequence info on vttablet on UpdateSequenceTables request (vitessio#18415) Fix watcher storm during topo outages (vitessio#18434) Online DDL: resume vreplication after cut-over/RENAME failure (vitessio#18428) Online DDL cutover enhancements (vitessio#18423) VStreamer: change in filter logic (vitessio#18319) Online DDL metrics: `OnlineDDLStaleMigrationMinutes` (vitessio#18417) Signed-off-by: Morgan Tocker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: Online DDL
Online DDL (vitess/native/gh-ost/pt-osc)
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new stats gauge for Online DDL,
OnlineDDLStaleMigrationMinutes.Vitess (vreplication based) migrations that are found
runningbut show no vreplication liveness in the past5seconds are logged, and the metricOnlineDDLStaleMigrationMinutesis updates as the highest number of staleness minutes among them.When all
runningmigrations have liveness within the5minrange, or if there's no running migrations, thenOnlineDDLStaleMigrationMinutesis set to zero.Related Issue(s)
Fixes #18416
Checklist
Deployment Notes