Skip to content

[v4.6] Fix Rubocop offenses for November 2025 #6387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tvdeyen merged 2 commits into from
Nov 26, 2025
Merged

[v4.6] Fix Rubocop offenses for November 2025 #6387

tvdeyen merged 2 commits into from
Nov 26, 2025
+7 −3

Conversation

@solidus-bot
Copy link

@solidus-bot solidus-bot bot commented Nov 26, 2025

Backport

This will backport the following commits from main to v4.6:

Questions ?

Please refer to the Backport tool documentation

@mamhoff
Disable Rubocop Rails/Exit locally
fa21c35 
This cop makes a lot of sense for the part of the app that runs
permanently, but both of these cases are instances where the code being
aborted is run as a one-off from the command line.

(cherry picked from commit 2341748)
@mamhoff
Rubocop: Fix presence cop violations
df52857 
These are fine.

(cherry picked from commit b773daa)
@solidus-bot solidus-bot bot requested a review from a team as a code owner November 26, 2025 07:27
@solidus-bot solidus-bot bot added changelog:solidus_core Changes to the solidus_core gem changelog:solidus_admin changelog:solidus_legacy_promotions Changes to the solidus_legacy_promotions gem labels Nov 26, 2025
@solidus-bot solidus-bot bot mentioned this pull request Nov 26, 2025
Merged
5 tasks
@tvdeyen tvdeyen enabled auto-merge November 26, 2025 07:30
@codecov
Copy link

codecov bot commented Nov 26, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.35%. Comparing base (14b3b33) to head (df52857).
⚠️ Report is 9 commits behind head on v4.6.

Additional details and impacted files 
@@           Coverage Diff           @@
##             v4.6    #6387   +/-   ##
=======================================
  Coverage   89.35%   89.35%           
=======================================
  Files         961      961           
  Lines       20195    20195           
=======================================
  Hits        18046    18046           
  Misses       2149     2149

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tvdeyen tvdeyen removed this from Solidus Admin Nov 26, 2025
@tvdeyen tvdeyen merged commit 2898f64 into v4.6 Nov 26, 2025
42 of 43 checks passed
@tvdeyen tvdeyen deleted the backport/v4.6/pr-6372 branch November 26, 2025 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tvdeyen tvdeyen tvdeyen approved these changes

@mamhoff mamhoff mamhoff approved these changes

Assignees

@mamhoff mamhoff

Labels

changelog:solidus_admin changelog:solidus_core Changes to the solidus_core gem changelog:solidus_legacy_promotions Changes to the solidus_legacy_promotions gem

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tvdeyen @mamhoff