Fix Rubocop offenses for November 2025

[mamhoff]

Summary

A new month, a new Rubocop version that has new cops.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

• I agree that my PR will be published under the same license as Solidus.
• I have written a thorough PR description.
• I have kept my commits small and atomic.
• I have localized any and all user-facing strings that I added to the source code.
• I have used clear, explanatory commit messages.

The following are not always needed:

• 📖 I have updated the README to account for my changes.
• 📑 I have documented new code with YARD.
• 🛣️ I have opened a PR to update the guides.
• ✅ I have added automated tests to cover my changes.
• 📸 I have attached screenshots to demo visual changes.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.44%. Comparing base (ed56090) to head (b773daa).
⚠️ Report is 59 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #6372   +/-   ##
=======================================
  Coverage   89.44%   89.44%           
=======================================
  Files         973      973           
  Lines       20298    20298           
=======================================
  Hits        18156    18156           
  Misses       2142     2142           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[forkata]

Thanks @mamhoff for this clean-up 🧹

[solidus-bot]

💚 All backports created successfully

Status	Branch	Result
✅	v4.6

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

[solidus-bot]

💔 Some backports could not be created

Status	Branch	Result
✅	v4.5
❌	v4.6	Cherrypick failed because the selected commit (2341748) is empty. It looks like the commit was already backported in #6387

Manual backport

To create the backport manually run:

backport --pr 6372

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details