Skip to content

Commit 2341748

Browse files
committed
Disable Rubocop Rails/Exit locally
This cop makes a lot of sense for the part of the app that runs permanently, but both of these cases are instances where the code being aborted is run as a one-off from the command line.
1 parent ed56090 commit 2341748

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

admin/lib/solidus_admin/testing_support/admin_assets.rb

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,9 @@
33
RSpec.configure do |config|
44
config.when_first_matching_example_defined(solidus_admin: true) do
55
config.before(:suite) do
6-
system('bin/rails solidus_admin:tailwindcss:build') or abort 'Failed to build Tailwind CSS'
6+
# rubocop:disable Rails/Exit
7+
system("bin/rails solidus_admin:tailwindcss:build") or abort "Failed to build Tailwind CSS"
8+
# rubocop:enable Rails/Exit
79
Rails.application.precompiled_assets
810
end
911
end

core/lib/generators/solidus/install/app_templates/authentication/existing.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,9 @@
44
user_class.classify.constantize
55
rescue NameError
66
say_status :error, "Can't find an existing user class named #{user_class.classify}, plese set up one before using this authentication option.", :red
7+
# rubocop:disable Rails/Exit
78
abort
9+
# rubocop:enable Rails/Exit
810
end
911

1012
generate "spree:custom_user #{user_class.shellescape}"

0 commit comments

Comments
 (0)