Skip to content

vtorc: rename ReplicationAnalysis -> DetectionAnalysis #18615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timvaillancourt merged 11 commits into from
Sep 23, 2025

Merge remote-tracking branch 'origin/main' into vtorc-rename-GetDetec…

d485431
Select commit
Loading
Failed to load commit list.
Merged

vtorc: rename ReplicationAnalysis -> DetectionAnalysis #18615

Merge remote-tracking branch 'origin/main' into vtorc-rename-GetDetec…
d485431
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 23, 2025 in 0s

67.52% (-0.01%) compared to 8236f03

View this Pull Request on Codecov

67.52% (-0.01%) compared to 8236f03

Details

Codecov Report

❌ Patch coverage is 40.78947% with 45 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.52%. Comparing base (8236f03) to head (d485431).

Files with missing lines Patch % Lines
go/vt/vtorc/logic/topology_recovery.go 0.00% 28 Missing ⚠️
go/vt/vtorc/inst/analysis_dao.go 81.08% 7 Missing ⚠️
go/vt/vtorc/server/api.go 20.00% 4 Missing ⚠️
go/vt/vtorc/inst/analysis.go 0.00% 3 Missing ⚠️
go/vt/vtorc/logic/topology_recovery_dao.go 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #18615      +/-   ##
==========================================
- Coverage   67.52%   67.52%   -0.01%     
==========================================
  Files        1608     1608              
  Lines      263611   263589      -22     
==========================================
- Hits       177994   177976      -18     
+ Misses      85617    85613       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov