vtorc: rename ReplicationAnalysis -> DetectionAnalysis

[timvaillancourt]

Description

Similar to #18351, this PR renames the term ReplicationAnalysis -> DetectionAnalysis in VTOrc, as the problems VTOrc detects and actions has expanded beyond just replication-related problems, making the old/existing name a bit confusing

While doing this rename, the big if statement in GetDetectionAnalysis was moved to use a switch statement to make it a bit easier to read

Related Issue(s)

Checklist

• "Backport to:" labels have been added if this change should be back-ported to release branches
• If this change is to be back-ported to previous releases, a justification is included in the PR description
• Tests were added or are not required
• Did the new or modified tests pass consistently locally and on CI?
• Documentation was added or is not required

Deployment Notes

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[codecov]

Codecov Report

❌ Patch coverage is 40.78947% with 45 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.52%. Comparing base (8236f03) to head (d485431).
⚠️ Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
go/vt/vtorc/logic/topology_recovery.go	0.00%	28 Missing ⚠️
go/vt/vtorc/inst/analysis_dao.go	81.08%	7 Missing ⚠️
go/vt/vtorc/server/api.go	20.00%	4 Missing ⚠️
go/vt/vtorc/inst/analysis.go	0.00%	3 Missing ⚠️
go/vt/vtorc/logic/topology_recovery_dao.go	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #18615      +/-   ##
==========================================
- Coverage   67.52%   67.52%   -0.01%     
==========================================
  Files        1608     1608              
  Lines      263611   263589      -22     
==========================================
- Hits       177994   177976      -18     
+ Misses      85617    85613       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[timvaillancourt]

Looks like we need more VTOrc reviewers. I've added a few reviewers at random until we sort out who the VTOrc CODEOWNERS should be 🙇