Add forward compatibility for caching_sha2_password and replication #18033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbussink
requested review from
GuptaManan100,
deepthi,
harshit-gangal,
mattlord,
shlomi-noach,
systay and
timvaillancourt
as code owners
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
dbussink
removed
NeedsDescriptionUpdate
5 tasks
This extracts the logic from vitessio#18010 for replication setup. There are cases during upgrades and downgrades where the following can happen: - The replication user is created on a newer version with caching2_sha_password. - We downgrade from this newer version to an older version. - The older version doesn't have the logic to add the GET_SOURCE_PUBLIC_KEY flag so it fails to re-enable replication. What this tells us, is that we need to first ship the change here to allow for future forward compatibility in v22, so we can change the default safely in v23. Signed-off-by: Dirkjan Bussink <[email protected]>
dbussink
force-pushed
the
dbussink/caching-sha2-forward-compat
branch
from
b05e797 to
b64b778
Compare
dbussink
commented
Mar 25, 2025
| if params.SslEnabled() { | ||
| args = append(args, "SOURCE_SSL = 1") | ||
| } else { | ||
| args = append(args, "GET_SOURCE_PUBLIC_KEY = 1") |
Member
Author
There was a problem hiding this comment.
See https://dev.mysql.com/doc/refman/8.4/en/change-replication-source-to.html#crs-opt-get_source_public_key for what this flag does. It's only needed when SSL is not used for replication.
shlomi-noach
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extracts the logic from #18010 for replication setup. There are cases during upgrades and downgrades where the following can happen:
What this tells us, is that we need to first ship the change here to allow for future forward compatibility in v22, so we can change the default safely in v23.
It's safe to also send down this flag even with using
mysql_native_password.Related Issue(s)
Part of #17966
Checklist