-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Switch to using the default caching sha2 password #18010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to using the default caching sha2 password #18010
Conversation
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
0bd3715 to
1df1bf6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18010 +/- ##
==========================================
- Coverage 67.58% 67.56% -0.02%
==========================================
Files 1598 1598
Lines 260270 260306 +36
==========================================
- Hits 175902 175886 -16
- Misses 84368 84420 +52 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
174bbb6 to
e8aeb56
Compare
|
Alright, in order to be safely able to do this, we first need to ship #18033 with v22 and then we can do this change for v23. |
This extracts the logic from vitessio#18010 for replication setup. There are cases during upgrades and downgrades where the following can happen: - The replication user is created on a newer version with caching2_sha_password. - We downgrade from this newer version to an older version. - The older version doesn't have the logic to add the GET_SOURCE_PUBLIC_KEY flag so it fails to re-enable replication. What this tells us, is that we need to first ship the change here to allow for future forward compatibility in v22, so we can change the default safely in v23. Signed-off-by: Dirkjan Bussink <[email protected]>
b2c9412 to
4293674
Compare
Test which parts fail with this change. Signed-off-by: Dirkjan Bussink <[email protected]>
Signed-off-by: Dirkjan Bussink <[email protected]>
4293674 to
1c311f7
Compare
After #18033 added forward compatibility in the upcoming v22, we can make it the default in v23.
Related Issue(s)
Part of #17966
Checklist