Skip to content

Conversation

@dbussink
Copy link
Member

@dbussink dbussink commented Mar 24, 2025

After #18033 added forward compatibility in the upcoming v22, we can make it the default in v23.

Related Issue(s)

Part of #17966

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

@vitess-bot
Copy link
Contributor

vitess-bot bot commented Mar 24, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Mar 24, 2025
@github-actions github-actions bot added this to the v22.0.0 milestone Mar 24, 2025
@dbussink dbussink force-pushed the dbussink/switch-caching-sha2-password branch 4 times, most recently from 0bd3715 to 1df1bf6 Compare March 24, 2025 10:54
@codecov
Copy link

codecov bot commented Mar 24, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.56%. Comparing base (470671c) to head (1df1bf6).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
go/mysql/flavor_mysql.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18010      +/-   ##
==========================================
- Coverage   67.58%   67.56%   -0.02%     
==========================================
  Files        1598     1598              
  Lines      260270   260306      +36     
==========================================
- Hits       175902   175886      -16     
- Misses      84368    84420      +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dbussink dbussink force-pushed the dbussink/switch-caching-sha2-password branch 2 times, most recently from 174bbb6 to e8aeb56 Compare March 24, 2025 19:02
@dbussink
Copy link
Member Author

Alright, in order to be safely able to do this, we first need to ship #18033 with v22 and then we can do this change for v23.

@dbussink dbussink modified the milestones: v22.0.0, v23.0.0 Mar 25, 2025
dbussink added a commit to planetscale/vitess that referenced this pull request Mar 25, 2025
This extracts the logic from vitessio#18010 for replication setup. There are
cases during upgrades and downgrades where the following can happen:

- The replication user is created on a newer version with
  caching2_sha_password.
- We downgrade from this newer version to an older version.
- The older version doesn't have the logic to add the
  GET_SOURCE_PUBLIC_KEY flag so it fails to re-enable replication.

What this tells us, is that we need to first ship the change here to
allow for future forward compatibility in v22, so we can change the
default safely in v23.

Signed-off-by: Dirkjan Bussink <[email protected]>
@dbussink dbussink force-pushed the dbussink/switch-caching-sha2-password branch 2 times, most recently from b2c9412 to 4293674 Compare April 1, 2025 21:25
@dbussink dbussink added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: TabletManager and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Apr 2, 2025
@dbussink dbussink marked this pull request as ready for review April 2, 2025 18:43
@dbussink dbussink requested a review from deepthi as a code owner April 2, 2025 18:43
dbussink added 2 commits April 3, 2025 10:08
Test which parts fail with this change.

Signed-off-by: Dirkjan Bussink <[email protected]>
@dbussink dbussink force-pushed the dbussink/switch-caching-sha2-password branch from 4293674 to 1c311f7 Compare April 3, 2025 08:17
@harshit-gangal harshit-gangal merged commit cf5f913 into vitessio:main Apr 7, 2025
101 checks passed
@harshit-gangal harshit-gangal deleted the dbussink/switch-caching-sha2-password branch April 7, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: TabletManager Type: Enhancement Logical improvement (somewhere between a bug and feature)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants