Skip to content

Refactor grpc flags for standardized naming #18009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rohit-nayak-ps merged 14 commits into from
Apr 5, 2025

Add TODO comments for underscore (_) flag deprecation in v25

469b3db
Select commit
Loading
Failed to load commit list.
Merged

Refactor grpc flags for standardized naming #18009

Add TODO comments for underscore (_) flag deprecation in v25
469b3db
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 23, 2025 in 0s

67.57% (+0.02%) compared to 0a9d1ee

View this Pull Request on Codecov

67.57% (+0.02%) compared to 0a9d1ee

Details

Codecov Report

Attention: Patch coverage is 76.36364% with 13 lines in your changes missing coverage. Please review.

Project coverage is 67.57%. Comparing base (0a9d1ee) to head (469b3db).

Files with missing lines Patch % Lines
go/vt/vtgate/grpcvtgateservice/server.go 20.00% 4 Missing ⚠️
go/vt/servenv/grpc_server_auth_static.go 33.33% 2 Missing ⚠️
go/vt/vttest/local_cluster.go 0.00% 2 Missing ⚠️
go/vt/vttest/vtprocess.go 33.33% 2 Missing ⚠️
go/cmd/vtadmin/main.go 0.00% 1 Missing ⚠️
go/vt/utils/flags.go 85.71% 1 Missing ⚠️
go/vt/vtctl/vtctl.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@                Coverage Diff                 @@
##           flags-refactor   #18009      +/-   ##
==================================================
+ Coverage           67.54%   67.57%   +0.02%     
==================================================
  Files                1598     1598              
  Lines              259808   259817       +9     
==================================================
+ Hits               175497   175566      +69     
+ Misses              84311    84251      -60

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov