-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Refactor grpc flags for standardized naming #18009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor grpc flags for standardized naming #18009
Conversation
Signed-off-by: mounicasruthi <[email protected]>
Signed-off-by: mounicasruthi <[email protected]>
Signed-off-by: mounicasruthi <[email protected]>
Signed-off-by: mounicasruthi <[email protected]>
Signed-off-by: mounicasruthi <[email protected]>
Signed-off-by: mounicasruthi <[email protected]>
Signed-off-by: mounicasruthi <[email protected]>
Signed-off-by: mounicasruthi <[email protected]>
Signed-off-by: mounicasruthi <[email protected]>
Signed-off-by: mounicasruthi <[email protected]>
Signed-off-by: mounicasruthi <[email protected]>
Signed-off-by: mounicasruthi <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: mounicasruthi <[email protected]>
Signed-off-by: mounicasruthi <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## flags-refactor #18009 +/- ##
==================================================
+ Coverage 67.54% 67.57% +0.02%
==================================================
Files 1598 1598
Lines 259808 259817 +9
==================================================
+ Hits 175497 175566 +69
+ Misses 84311 84251 -60 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rohit-nayak-ps
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
| # mise files | ||
| .mise.toml | ||
| /errors/ | ||
| go/flags/endtoend/count_flags.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add this to git for now. We can remove once the refactor is done. You can do this in a future PR, don't want to hold this one up for it.
7f16f70
into
vitessio:flags-refactor
Signed-off-by: mounicasruthi <[email protected]>
Signed-off-by: mounicasruthi <[email protected]>
Description
This PR is a part of an ongoing change to support the transition from underscores (
_) to dashes (-) in flag naming conventions.Flags Updated in This PR:
--grpc-auth-mode
--grpc-auth-mtls-allowed-substrings
--grpc-auth-static-client-creds
--grpc-auth-static-password-file
--grpc-bind-address
--grpc-ca
--grpc-cert
--grpc-compression
--grpc-crl
--grpc-dial-concurrency-limit
--grpc-enable-optional-tls
--grpc-enable-tracing
--grpc-initial-conn-window-size
--grpc-initial-window-size
--grpc-keepalive-time
--grpc-keepalive-timeout
--grpc-key
--grpc-max-connection-age
--grpc-max-connection-age-grace
--grpc-max-message-size
--grpc-port
--grpc-prometheus
--grpc-server-ca
--grpc-server-initial-conn-window-size
--grpc-server-initial-window-size
--grpc-server-keepalive-enforcement-policy-min-time
--grpc-server-keepalive-enforcement-policy-permit-without-stream
--grpc-server-keepalive-time
--grpc-server-keepalive-timeout
--grpc-use-effective-callerid
--grpc-use-effective-groups
--grpc-use-static-authentication-callerid
Flag Count Before vs After:
_-# of migrated flags: 234
Related Issue(s)
#17880
Checklist