Skip to content

Polish async test by removing sleep in DefaultAsyncServerResponseTests #35993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hydrationn wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −9
Open

Polish async test by removing sleep in DefaultAsyncServerResponseTests #35993

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions ...c/test/java/org/springframework/web/servlet/function/DefaultAsyncServerResponseTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,17 +39,11 @@ void blockCompleted() {
@Test
void blockNotCompleted() {
ServerResponse wrappee = ServerResponse.ok().build();
CompletableFuture<ServerResponse> future = CompletableFuture.supplyAsync(() -> {
try {
Thread.sleep(500);
return wrappee;
}
catch (InterruptedException ex) {
throw new RuntimeException(ex);
}
});
CompletableFuture<ServerResponse> future = new CompletableFuture<>();
AsyncServerResponse response = AsyncServerResponse.create(future);

new Thread(() -> future.complete(wrappee)).start();

assertThat(response.block()).isSameAs(wrappee);
}

Expand Down