Polish async test by removing sleep in DefaultAsyncServerResponseTests #35993
+3
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes Thread.sleep from async tests in DefaultAsyncServerResponseTests
and replaces it with a non-blocking CompletableFuture pattern. This makes the
test more deterministic and avoids timing-based flakiness.
🔍 What was changed
Thread.sleep(500)insideCompletableFuture.supplyAsyncCompletableFuturenew Thread(() -> future.complete(...))💡 Why this change
Using
Thread.sleepin tests is generally discouraged because:The updated approach ensures:
📌 Notes
No functional changes were made to production code.
This update improves the internal test quality and stability.