-
Notifications
You must be signed in to change notification settings - Fork 180
JP-3930: coron tests and minor fixes #9693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Regtests: All passing. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9693 +/- ##
=======================================
Coverage ? 82.49%
=======================================
Files ? 366
Lines ? 37129
Branches ? 0
=======================================
Hits ? 30629
Misses ? 6500
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0da643f to
b33d419
Compare
stscirij
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look great! 100% coverage too. As usual I learned a bunch by looking at this
7db2a25 to
68ba77d
Compare
ffd04a0 to
b2b89f6
Compare
b2b89f6 to
25727ca
Compare
25727ca to
9e867cc
Compare
tapastro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Partially resolves JP-3930
While adding some basic smoke tests for the coron steps for JP-3930, I noticed a couple minor bugs:
I fixed these here and filled out unit test coverage to 100%.
I also noticed that HlspStep is unused in any pipeline, has not been modified recently, and expects different inputs than the rest of the coron steps. I filed JP-4069 to ask if we should remove or update it.
I think no changelog entry is needed, since the bugs were not likely to have been encountered by users, but I can add one if desired.
Tasks
Build 12.0(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see changelog readme for instructions)docs/pageokify_regteststo update the truth files