Skip to content

Conversation

@melanieclarke
Copy link
Collaborator

@melanieclarke melanieclarke commented Jul 24, 2025

Partially resolves JP-3930

While adding some basic smoke tests for the coron steps for JP-3930, I noticed a couple minor bugs:

  • AlignRefsStep returns None if no reference file is found
  • KlipStep does not close the PSF model after opening it
  • median_image_replace crashes for MIRI data if there are no bad pixels
  • median_image_replace handles NaNs incorrectly if they're not flagged in the DQ plane

I fixed these here and filled out unit test coverage to 100%.

I also noticed that HlspStep is unused in any pipeline, has not been modified recently, and expects different inputs than the rest of the coron steps. I filed JP-4069 to ask if we should remove or update it.

I think no changelog entry is needed, since the bugs were not likely to have been encountered by users, but I can add one if desired.

Tasks

  • If you have a specific reviewer in mind, tag them.
  • add a build milestone, i.e. Build 12.0 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see changelog readme for instructions)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly

@melanieclarke
Copy link
Collaborator Author

melanieclarke commented Jul 24, 2025

@codecov
Copy link

codecov bot commented Jul 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@e5d37a1). Learn more about missing BASE report.
⚠️ Report is 230 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9693   +/-   ##
=======================================
  Coverage        ?   82.49%           
=======================================
  Files           ?      366           
  Lines           ?    37129           
  Branches        ?        0           
=======================================
  Hits            ?    30629           
  Misses          ?     6500           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@melanieclarke melanieclarke marked this pull request as ready for review July 24, 2025 17:47
@melanieclarke melanieclarke requested a review from a team as a code owner July 24, 2025 17:47
@melanieclarke melanieclarke requested a review from stscirij July 24, 2025 17:47
Copy link
Contributor

@stscirij stscirij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look great! 100% coverage too. As usual I learned a bunch by looking at this

Copy link
Contributor

@tapastro tapastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@melanieclarke melanieclarke merged commit dee4584 into spacetelescope:main Aug 18, 2025
31 checks passed
@melanieclarke melanieclarke deleted the coron_tests branch August 18, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants