-
Notifications
You must be signed in to change notification settings - Fork 180
JP-3930: Make sure input is not modified inside Steps #9725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
327b8a4 to
029086e
Compare
tapastro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I don't see any lingering questions. The last RT run was clean - I assume we are not expecting failures? We can get this in and start a new run to be safe.
No expected failures! I'll go ahead and merge and start a new run. |
Resolves JP-3930
Adding smoke tests for all steps for as many input cases as possible and fixing any issues with input modification revealed by the tests.
Some steps addressed separately:
background: #9688
coron: #9693
outlier_detection: #9709
skymatch, tweakreg, assign_mtwcs: #9723
tso_photometry: #9579 and/or #9627
Tasks
Build 12.0(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see changelog readme for instructions)docs/pageokify_regteststo update the truth files