Skip to content

Conversation

@pllim
Copy link
Collaborator

@pllim pllim commented Jul 17, 2025

Exorcise zero coverage (try 2). Follow-up of #9550

Tasks

  • If you have a specific reviewer in mind, tag them.
  • add a build milestone, i.e. Build 12.0 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see changelog readme for instructions)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly

@codecov
Copy link

codecov bot commented Jul 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.11%. Comparing base (8409d2b) to head (0c73894).
⚠️ Report is 362 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##            main    #9660       +/-   ##
==========================================
+ Coverage   0.00%   79.11%   +79.11%     
==========================================
  Files        367      368        +1     
  Lines      37332    37222      -110     
==========================================
+ Hits           0    29447    +29447     
+ Misses     37332     7775    -29557     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This was referenced Jul 17, 2025
@pllim pllim requested review from braingram and jhunkeler July 17, 2025 01:42
@pllim pllim marked this pull request as ready for review July 17, 2025 01:42
@pllim pllim requested a review from a team as a code owner July 17, 2025 01:42
@pllim
Copy link
Collaborator Author

pllim commented Jul 17, 2025

I think this is the correct fix. Turns out jwst wasn't running the test suite in true isolated env from clean directory outside of source tree. Now all jobs use the consistent pyargs setup and the coverage number is back.

But again, please review logs carefully in case I missed something. Thanks for your patience!

@pllim
Copy link
Collaborator Author

pllim commented Jul 17, 2025

p.s. Turns out regression test suite isn't using tox at all, so no need to run RT. (Which brings me to my next PR that I am about to open... #9661)

@pllim pllim requested a review from emolter July 17, 2025 01:44
Copy link
Collaborator

@braingram braingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Quick merge before the test number changes again 😛

@tapastro tapastro merged commit 66c1168 into spacetelescope:main Jul 17, 2025
28 checks passed
@pllim pllim deleted the pyargh-try2 branch July 17, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants