-
Notifications
You must be signed in to change notification settings - Fork 180
TST: Remove pyargs from toxenv #9550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a76643e to
28e5052
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9550 +/- ##
==========================================
- Coverage 80.66% 0.00% -80.67%
==========================================
Files 368 368
Lines 37294 37224 -70
==========================================
- Hits 30085 0 -30085
- Misses 7209 37224 +30015 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
If switching all runs to |
|
skipped didn't increase... I will need to inject The other side: https://github.com/spacetelescope/jwst/actions/runs/15691575132/job/44207821448?pr=9553 |
|
@braingram , look better now? |
|
Thanks! Test numbers look to match. What wasn't being included that required the namespace packages? Given the impending build and that this changes the CI my vote is to wait until after the release. |
|
Hard to tell at a glance. Will have to extract the test names and sort them and compare. But since you want to wait, there is no rush to do this. Thanks! |
|
OK I think I figured out why. The tests folders in charge_migration and skymatch do not have |
because it is now used in everything
[ci skip]
[ci skip]
f00720f to
7e2c16d
Compare
|
The test count now is same as |
melanieclarke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- I'll go ahead and get this in.
|
@meeseeksdev backport to release/1.19.x |
…oxenv) (#9628) Co-authored-by: Melanie Clarke <[email protected]>
This PR to remove
pyargsfromtoxenvbecause it is now used in everything. I do not think we need!pyargs. Indirect follow-up of #9545Tasks
Build 12.0(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see changelog readme for instructions)docs/pageokify_regteststo update the truth files