Skip to content

Conversation

@pllim
Copy link
Collaborator

@pllim pllim commented Jun 16, 2025

This PR to remove pyargs from toxenv because it is now used in everything. I do not think we need !pyargs. Indirect follow-up of #9545

Tasks

  • If you have a specific reviewer in mind, tag them.
  • add a build milestone, i.e. Build 12.0 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see changelog readme for instructions)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly

@pllim pllim added this to the Build 12.0 milestone Jun 16, 2025
@github-actions github-actions bot added testing automation Continuous Integration (CI) and testing automation tools labels Jun 16, 2025
@pllim pllim force-pushed the arg-arg-arg-pyargs branch from a76643e to 28e5052 Compare June 16, 2025 18:19
@codecov
Copy link

codecov bot commented Jun 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (8160ced) to head (0f95622).
⚠️ Report is 415 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #9550       +/-   ##
==========================================
- Coverage   80.66%   0.00%   -80.67%     
==========================================
  Files         368     368               
  Lines       37294   37224       -70     
==========================================
- Hits        30085       0    -30085     
- Misses       7209   37224    +30015     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pllim pllim marked this pull request as ready for review June 16, 2025 18:48
@pllim pllim requested a review from a team as a code owner June 16, 2025 18:48
@braingram
Copy link
Collaborator

If switching all runs to pyargs is preferred some test changes will be needed. With this PR fewer tests are being run:
https://github.com/spacetelescope/jwst/actions/runs/15688696764/job/44198349903?pr=9550
=========== 3209 passed, 942 skipped, 1 xfailed in 724.24s (0:12:04) ===========
compared to on main:
https://github.com/spacetelescope/jwst/actions/runs/15688669586/job/44198243232
=========== 3361 passed, 942 skipped, 1 xfailed in 794.86s (0:13:14) ===========

@pllim
Copy link
Collaborator Author

pllim commented Jun 16, 2025

skipped didn't increase... I will need to inject -v on both sides to see what is really missing.

The other side: https://github.com/spacetelescope/jwst/actions/runs/15691575132/job/44207821448?pr=9553

@pllim
Copy link
Collaborator Author

pllim commented Jun 16, 2025

@braingram , look better now?

@braingram
Copy link
Collaborator

Thanks! Test numbers look to match. What wasn't being included that required the namespace packages? Given the impending build and that this changes the CI my vote is to wait until after the release.

@pllim
Copy link
Collaborator Author

pllim commented Jun 16, 2025

Hard to tell at a glance. Will have to extract the test names and sort them and compare. But since you want to wait, there is no rush to do this. Thanks!

@pllim
Copy link
Collaborator Author

pllim commented Jun 17, 2025

OK I think I figured out why. The tests folders in charge_migration and skymatch do not have __init__.py files to declare themselves for discovery. Let me push some commit(s) and see.

@pllim pllim requested a review from a team as a code owner June 17, 2025 02:12
@pllim pllim force-pushed the arg-arg-arg-pyargs branch from f00720f to 7e2c16d Compare June 17, 2025 02:14
@pllim
Copy link
Collaborator Author

pllim commented Jun 17, 2025

The test count now is same as main: 3361 passed, 942 skipped, 1 xfailed

@melanieclarke melanieclarke modified the milestones: Build 12.0, Build 12.1 Jun 20, 2025
Copy link
Collaborator

@melanieclarke melanieclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- I'll go ahead and get this in.

@melanieclarke melanieclarke enabled auto-merge July 9, 2025 18:15
@melanieclarke melanieclarke merged commit b754faa into spacetelescope:main Jul 9, 2025
27 of 28 checks passed
@pllim pllim deleted the arg-arg-arg-pyargs branch July 9, 2025 20:18
@tapastro
Copy link
Contributor

@meeseeksdev backport to release/1.19.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automation Continuous Integration (CI) and testing automation tools installation no-changelog-entry-needed skymatch testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants