Skip to content

Trap divide-by-zero in jump step #7723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hbushouse merged 4 commits into from
Jul 10, 2023
Merged

Trap divide-by-zero in jump step #7723

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3d971e5
Update jump.py
mwregan2 Jul 10, 2023
732ca3e
Update CHANGES.rst
mwregan2 Jul 10, 2023
08b5b6d
Update CHANGES.rst
mwregan2 Jul 10, 2023
66262f9
Merge branch 'master' into SKIP_CR_COUNT_IF_NO_USABLE_GROUPS
hbushouse Jul 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,11 @@ documentation

- Fix minor formatting typos in associations docs. [#7694]

jump
----
- Added a test to prevent a divide by zero when the numger of usable
groups is less than one. [#7723]

tweakreg
--------

Expand Down
11 changes: 6 additions & 5 deletions jwst/jump/jump.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,10 +99,11 @@ def run_detect_jumps(input_model, gain_model, readnoise_model,
if np.all(np.bitwise_and(gdq[integ, grp, :, :], dnu_flag)):
num_flagged_grps += 1
total_groups = data.shape[0] * data.shape[1] - num_flagged_grps - data.shape[0]
total_time = output_model.meta.exposure.group_time * total_groups
total_pixels = data.shape[2] * data.shape[3]
output_model.meta.exposure.primary_cosmic_rays = 1000 * number_crs / (total_time * total_pixels)
output_model.meta.exposure.extended_emission_events = 1e6 * number_extended_events /\
(total_time * total_pixels)
if total_groups >= 1:
total_time = output_model.meta.exposure.group_time * total_groups
total_pixels = data.shape[2] * data.shape[3]
output_model.meta.exposure.primary_cosmic_rays = 1000 * number_crs / (total_time * total_pixels)
output_model.meta.exposure.extended_emission_events = 1e6 * number_extended_events /\
(total_time * total_pixels)

return output_model