Skip to content

Conversation

@mwregan2
Copy link
Contributor

@mwregan2 mwregan2 commented Jul 10, 2023

This PR addresses a bug found in DMS B9.3 testing, such that when there are no usable groups, the code calculating the number of CRs per second divides by zero.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@mwregan2 mwregan2 requested a review from a team as a code owner July 10, 2023 15:44
@github-actions github-actions bot added the jump label Jul 10, 2023
@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (041c730) 76.56% compared to head (08b5b6d) 76.56%.

❗ Current head 08b5b6d differs from pull request most recent head 66262f9. Consider uploading reports for the commit 66262f9 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7723   +/-   ##
=======================================
  Coverage   76.56%   76.56%           
=======================================
  Files         456      456           
  Lines       36877    36878    +1     
=======================================
+ Hits        28234    28235    +1     
  Misses       8643     8643           
Flag Coverage Δ *Carryforward flag
nightly 77.43% <ø> (ø) Carriedforward from 041c730

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
jwst/jump/jump.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hbushouse hbushouse changed the title Update jump.py Fix bug in computation of EXTNCRS in jump step Jul 10, 2023
@hbushouse hbushouse added this to the Build 9.3 milestone Jul 10, 2023
@hbushouse hbushouse added the bug label Jul 10, 2023
Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK

@hbushouse hbushouse changed the title Fix bug in computation of EXTNCRS in jump step Trap divide-by-zero in jump step Jul 10, 2023
@hbushouse
Copy link
Collaborator

Regression test run at https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/780/ has unrelated failures.

@hbushouse hbushouse merged commit 19f3349 into spacetelescope:master Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants