Skip to content

Fix DummyApp Generator #6121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tvdeyen merged 3 commits into from
Feb 13, 2025
Merged

Fix DummyApp Generator #6121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e917ec
DummyGenerator: Remove unused script/rails file
tvdeyen Feb 13, 2025
8ffb532
DummyGenerator: Update application template
tvdeyen Feb 13, 2025
16fcb10
DummyGenerator: Add Sprockets manifest
tvdeyen Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/lib/generators/spree/dummy/dummy_generator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ def test_dummy_config
template "rails/application.rb.tt", "#{dummy_path}/config/application.rb", force: true
template "rails/routes.rb", "#{dummy_path}/config/routes.rb", force: true
template "rails/test.rb", "#{dummy_path}/config/environments/test.rb", force: true
template "rails/script/rails", "#{dummy_path}/spec/dummy/script/rails", force: true
template "rails/manifest.js", "#{dummy_path}/app/assets/config/manifest.js", force: true
end

def test_dummy_inject_extension_requirements
Expand Down
2 changes: 1 addition & 1 deletion core/lib/generators/spree/dummy/templates/rails/application.rb.tt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ require File.expand_path('../boot', __FILE__)

require 'rails/all'

Bundler.require(*Rails.groups(assets: %w(development test)))
Bundler.require(*Rails.groups)

require '<%= lib_name %>'

Expand Down
3 changes: 3 additions & 0 deletions core/lib/generators/spree/dummy/templates/rails/manifest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
//= link_tree ../images
//= link_directory ../javascripts .js
//= link_directory ../stylesheets .css
6 changes: 0 additions & 6 deletions core/lib/generators/spree/dummy/templates/rails/script/rails
View file
Open in desktop

This file was deleted.

Loading