Fix DummyApp Generator #6121
Merged
Fix DummyApp Generator #6121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file gets copied into the wrong folder and is not used by Rails since decades.
We do not have production group in generated dummy apps and the syntax is outdated. This is what the Rails engine generator does as well. So let's stick with the framework
Rails stopped creating sprockets files but we still use sprockets. And we need to manifest so that test apps generated during specs do not fail with a sprockets error.
github-actions
bot
added
the
changelog:solidus_core
tvdeyen
added a commit
to tvdeyen/solidus_dev_support
that referenced
this pull request
Feb 13, 2025
Temporarily test solidusio/solidus#6121
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6121 +/- ##
==========================================
+ Coverage 88.68% 92.43% +3.74%
==========================================
Files 830 389 -441
Lines 18013 8008 -10005
==========================================
- Hits 15975 7402 -8573
+ Misses 2038 606 -1432 ☔ View full report in Codecov by Sentry. |
tvdeyen
added a commit
to tvdeyen/solidus_dev_support
that referenced
this pull request
Feb 13, 2025
Temporarily test solidusio/solidus#6121
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove some old unused files and add a sprockets manifest so that latest versions of Rails and Solidus main.
Rails stopped creating sprockets files but we still use sprockets. And we need to manifest so that test apps
generated during specs do not fail with a sprockets error.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: