Skip to content

Conversation

@LikhithaEda
Copy link
Contributor

No description provided.

@LikhithaEda LikhithaEda force-pushed the local branch 5 times, most recently from 28162e6 to f6d1efe Compare August 4, 2021 15:02
@wheelerlaw
Copy link
Contributor

Overall. looks good. But please reformat the code to follow PEP-8 standards. The most notable thing is the indentation, all python code should be indented with either tabs or spaces in multiples of 4.

@LikhithaEda LikhithaEda force-pushed the local branch 4 times, most recently from 23ce115 to 3a9299b Compare August 5, 2021 17:54
@jsztuka
Copy link
Contributor

jsztuka commented Aug 6, 2021

/retest CVP

Copy link

@lslebodn lslebodn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not clear to me what do we want to achieve with this script.
How it will be useful.

The use-case in https://operator-framework.github.io/community-operators/stats/
was different. Applying the same patter for every repository will not generate the same results.
Cause each repository have different purpose.

Anyway binary files should bot be part of MR.

@lslebodn
Copy link

lslebodn commented Aug 6, 2021

/retest CVP

@openshift-ci
Copy link

openshift-ci bot commented Aug 6, 2021

@lslebodn: No presubmit jobs available for redhat-openshift-ecosystem/operator-test-playbooks@master

In response to this:

/retest CVP

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@LikhithaEda
Copy link
Contributor Author

It is not clear to me what do we want to achieve with this script.
How it will be useful.

The use-case in https://operator-framework.github.io/community-operators/stats/
was different. Applying the same patter for every repository will not generate the same results.
Cause each repository have different purpose.

Anyway binary files should bot be part of MR.

This script will only work on this repo. And it will analyze the PR history on this repo.

@LikhithaEda LikhithaEda force-pushed the local branch 3 times, most recently from 92f37cd to 7e68614 Compare August 9, 2021 18:44
@jsztuka
Copy link
Contributor

jsztuka commented Aug 10, 2021

I would love to see the output of the functions that are mentioned in your PR, do you have some sort of example output? Please share where did you developed this task, what environment did you use, test data.

@LikhithaEda
Copy link
Contributor Author

LikhithaEda commented Aug 10, 2021

I would love to see the output of the functions that are mentioned in your PR, do you have some sort of example output? Please share where did you developed this task, what environment did you use, test data.

The example output can be found in PRmergeRates.png, AvgMergeTimes.png, and PR_Info_Monthly.csv files which are attached in this PR and also shown in the README

@wheelerlaw
Copy link
Contributor

Anyway binary files should bot be part of MR.

This story is to create a similar report to the one here. That repository has binary images committed to it without any issues, so including binary images here is not a problem.

It is not clear to me what do we want to achieve with this script.
How it will be useful.

The use-case in https://operator-framework.github.io/community-operators/stats/
was different. Applying the same patter for every repository will not generate the same results.
Cause each repository have different purpose.

So I think the purpose is to create a dashboard to mimic the statistics reporting that is done in that repository. This was selected as a good intern task. I agree that the use case was different for that repository but the information that is generated from this repository can still have benefit, but more so a good benefit for being something useful for Likhitha to work on.

@LikhithaEda LikhithaEda force-pushed the local branch 2 times, most recently from 416fb16 to 4512e5a Compare August 10, 2021 22:15
@jsztuka
Copy link
Contributor

jsztuka commented Aug 11, 2021

/retest

Copy link
Contributor

@jsztuka jsztuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsztuka
Copy link
Contributor

jsztuka commented Aug 11, 2021

You did a very good job.

@wheelerlaw wheelerlaw merged commit 04fe535 into redhat-openshift-ecosystem:master Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants