-
Notifications
You must be signed in to change notification settings - Fork 41
CVP-2129 Visualize PRs merged in CVP's Operator Test Playbook project repo #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CVP-2129 Visualize PRs merged in CVP's Operator Test Playbook project repo #207
Conversation
28162e6 to
f6d1efe
Compare
|
Overall. looks good. But please reformat the code to follow PEP-8 standards. The most notable thing is the indentation, all python code should be indented with either tabs or spaces in multiples of 4. |
23ce115 to
3a9299b
Compare
|
/retest CVP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not clear to me what do we want to achieve with this script.
How it will be useful.
The use-case in https://operator-framework.github.io/community-operators/stats/
was different. Applying the same patter for every repository will not generate the same results.
Cause each repository have different purpose.
Anyway binary files should bot be part of MR.
|
/retest CVP |
|
@lslebodn: No presubmit jobs available for redhat-openshift-ecosystem/operator-test-playbooks@master In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This script will only work on this repo. And it will analyze the PR history on this repo. |
92f37cd to
7e68614
Compare
|
I would love to see the output of the functions that are mentioned in your PR, do you have some sort of example output? Please share where did you developed this task, what environment did you use, test data. |
The example output can be found in PRmergeRates.png, AvgMergeTimes.png, and PR_Info_Monthly.csv files which are attached in this PR and also shown in the README |
This story is to create a similar report to the one here. That repository has binary images committed to it without any issues, so including binary images here is not a problem.
So I think the purpose is to create a dashboard to mimic the statistics reporting that is done in that repository. This was selected as a good intern task. I agree that the use case was different for that repository but the information that is generated from this repository can still have benefit, but more so a good benefit for being something useful for Likhitha to work on. |
416fb16 to
4512e5a
Compare
|
/retest |
jsztuka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
You did a very good job. |
No description provided.