Skip to content

Conversation

@primer
Copy link
Contributor

@primer primer bot commented Nov 25, 2025

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@primer/[email protected]

Minor Changes

  • #1195 55474b4 Thanks @rezrah! - Improved support for React v19.

    All components now have improved support for React v19 type signatures, in addition to continued backwards compatibility with React v18.

    As part of this change, the following has changed:

    • Refs as props are now handled correctly in FAQGroup, ActionMenu, Bento, Button/ButtonGroup, and other compound components.
    • Removed internal type casting on various components. This ensures that props are inferred correctly using the new JSX runtime in React v19.
    • Removed internal dependency on react-is for Fragment detection

    No changes to component behavior or presentation is expected as part of this change.

@primer/[email protected]

@primer/[email protected]

@primer/[email protected]

@primer/[email protected]

@primer/[email protected]

@primer/[email protected]

@github-actions github-actions bot force-pushed the changeset-release/main branch from 180fde8 to 0f6cc35 Compare November 25, 2025 16:12
@primer primer bot requested a review from a team as a code owner November 25, 2025 16:12
@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2025

❗ Pre-merge checklist

Please ensure these items are checked before merging.

✅ Preliminary checks

  • All CI checks pass on this pull request
  • Docs and Storybook previews open in a browser

🔌 Integration smoke tests

Dotcom

  • Performed successful integration test with github/github-ui, as a primary consumer of Primer Brand
    • Install RC: npm install @primer/react-brand@{RC_VERSION} -w @github-ui/swp-core
    • Run development server
    • Manually verify release-specific bugfixes and/or features on the following pages:
      • /home
      • /features/copilot
      • /features/copilot/plans
      • /features/copilot/tutorials
      • /features/preview
      • /enterprise
      • /enterprise/contact
      • /security/advanced-security
      • /education
      • /mobile
      • /about/diversity
      • /newsroom
      • /resources/articles
      • /resources/articles/software-development
      • /resources/articles/software-development/what-is-cloud-native
      • /resources/whitepapers
      • /resources/whitepapers/how-the-c-suite-can-lead-ai-innovation
      • /solutions
      • /solutions/use-case/
      • /solutions/use-case/devops
      • /contentful-lp-tests/flex-example-dark (requires a flag)
      • /contentful-lp-tests/flex-example-light (requires a flag)
    • Manually compare production site to local instance for any non-release specific regressions

Subdomain sites

  • Performed successful integration test with githubuniverse.com, as a Tier 1 consumer of Primer Brand outside of the monolith.

    • Run development server and verify no new console warnings or regressions are found
    • Run local build to verify the release compiles correctly
    • Manually performed side-by-side comparison with production
  • Performed successful integration test with https://resources.github.com/, as a Tier 1 consumer of Primer Brand outside of the monolith.

    • Run development server and verify no new console warnings or regressions are found
    • Run local build to verify the release compiles correctly
    • Manually performed side-by-side comparison with production

Sandboxes

  • Works in CodeSandbox or StackBlitz
    • New components render successfully
    • (optional) Tested in both SPA and SSR apps if release contains build changes

🤔 Cross-check (aka sanity test)

  • Release notes accurately describe the changes made
  • All bugfixes in this release have resolved their corresponding issues
  • The issues for reverted PRs have been re-opened and commented on with a link to the reverted PR
  • No noticeable regressions or side-effects have not been introduced as a result of changes in this release.
    • If they have, determine severity of the issue and consider hotfixing

After tests

  • Add report summary of your findings, including any images. Use following template as a guide:

    #### Smoke test results
    
    - Feature 1 🟢 🟡 🔴 (choose one, depending on success levels)
    
      {insert screenshot}
    
    Release testing status: Ready to release 🟢 | Paused 🟡 🔴 (choose one and provide reason)

🚢 After merge

  • Issue release comms in primer brand Slack channel
  • Add the preview deployment's link to releases as a way of permalinking to old version's docs. Example

@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2025

🟢 No design token changes found

@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2025

🟢 No unit test coverage changes found

All components and hooks with tests maintain the same coverage as the main branch.

@primer primer bot temporarily deployed to github-pages November 25, 2025 16:16 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2025

🟢 No visual differences found

Our visual comparison tests did not find any differences in the UI.

@github-actions github-actions bot force-pushed the changeset-release/main branch 2 times, most recently from 9f8ba1d to 1479aae Compare November 25, 2025 17:09
@danielguillan
Copy link
Contributor

Smoke test results

  • Improved support for React v19 🟢

No issues, regressions, or new console warnings observed. All tests and type-checks were successfully run for all packages using Primer Brand in dotcom. Any failing tests were identified as originating outside of Primer Brand.

Testing was conducted with both the current React v18 and v19. The v19 was tested using the react_next flag, with updated dependencies, and on top of https://github.com/github/github-ui/pull/6482.

Release testing status: Ready to release 🟢

@danielguillan danielguillan merged commit 42fb5ad into main Nov 27, 2025
23 checks passed
@danielguillan danielguillan deleted the changeset-release/main branch November 27, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants