Skip to content

Conversation

@rezrah
Copy link
Collaborator

@rezrah rezrah commented Nov 25, 2025

Summary

Updates our release CI workflows to use the Primer GitHub app instead of the previous OIDC tokens. This is needed because our Release Tracking PRs are not publishing the RC npm package correctly: #1199

List of notable changes:

  • Replaces GITHUB_TOKEN with a token generated from the Primer GitHub app. This has elevated permissions, and will allow other bot actors to publish packages correctly.

Steps to test:

  1. GitHub Actions should continue to publish canarys in PRs like this.

Contributor checklist:

  • All new and existing CI checks pass
  • Tests prove that the feature works and covers both happy and unhappy paths
  • Any drop in coverage, breaking changes or regressions have been documented above
  • UI Changes contain new visual snapshots (generated by adding update snapshots label to the PR)
  • All developer debugging and non-functional logging has been removed
  • Related issues have been referenced in the PR description

Reviewer checklist:

  • Check that pull request and proposed changes adhere to our contribution guidelines and code of conduct
  • Check that tests prove the feature works and covers both happy and unhappy paths
  • Check that there aren't other open Pull Requests for the same update/change

Screenshots:

Please try to provide before and after screenshots or videos

Before After

@changeset-bot
Copy link

changeset-bot bot commented Nov 25, 2025

⚠️ No Changeset found

Latest commit: 05443c2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

🟢 No design token changes found

@rezrah rezrah marked this pull request as ready for review November 25, 2025 16:32
@rezrah rezrah requested a review from a team as a code owner November 25, 2025 16:32
Copilot AI review requested due to automatic review settings November 25, 2025 16:32
@rezrah
Copy link
Collaborator Author

rezrah commented Nov 25, 2025

This PR is publishing the package using the GitHub app token, so this should also fix the RC now too.

Screenshot 2025-11-25 at 16 32 48

Copilot finished reviewing on behalf of rezrah November 25, 2025 16:34
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the release workflow to use GitHub App authentication instead of the default GITHUB_TOKEN for four release jobs. This change addresses an issue where Release Tracking PRs were not correctly publishing RC npm packages.

Key Changes:

  • Adds GitHub App token generation step to four jobs: release-next-minor, release-candidate, release-candidate-next-minor, and release-canary
  • Replaces secrets.GITHUB_TOKEN with app-generated token in GITHUB_TOKEN environment variable for these jobs
Comments suppressed due to low confidence (1)

.github/workflows/release.yml:11

  • The comment 'Required for OIDC' is now misleading since the workflow has been migrated to use GitHub App tokens instead of OIDC tokens. This permission may no longer be necessary and the comment should be updated or removed to reflect the current authentication approach.
  id-token: write # Required for OIDC

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@rezrah rezrah merged commit ea0449d into main Nov 25, 2025
27 checks passed
@rezrah rezrah deleted the rezrah/update-canary-token branch November 25, 2025 16:35
@github-actions
Copy link
Contributor

🟢 No visual differences found

Our visual comparison tests did not find any differences in the UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants