Can't edit formula using EDITOR=code brew edit wget with VS Code remote development

[wheelerlaw]

Output of brew config

HOMEBREW_VERSION: 4.6.20
ORIGIN: https://github.com/Homebrew/brew
HEAD: 71358caec4959d8c06b9d469ebc09fa7aa7a210e
Last commit: 10 days ago
Branch: stable
Core tap HEAD: a22ab851308f4881f04a84edd45be34cfdcd7fcf
Core tap last commit: 7 days ago
HOMEBREW_PREFIX: /home/linuxbrew/.linuxbrew
HOMEBREW_BROWSER: /home/ec2-user/.vscode-server/cli/servers/Stable-03c265b1adee71ac88f833e065f7bb956b60550a/server/bin/helpers/browser.sh
HOMEBREW_CASK_OPTS: []
HOMEBREW_DOWNLOAD_CONCURRENCY: 8
HOMEBREW_EDITOR: nano
HOMEBREW_FORBID_PACKAGES_FROM_PATHS: set
HOMEBREW_MAKE_JOBS: 4
HOMEBREW_NO_INSTALL_FROM_API: set
HOMEBREW_SORBET_RUNTIME: set
Homebrew Ruby: 3.4.5 => /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/portable-ruby/3.4.5/bin/ruby
CPU: quad-core 64-bit unknown_0x17_0x1
Clang: N/A
Git: 2.43.7 => /bin/git
Curl: 7.61.1 => /bin/curl
Kernel: Linux 4.18.0-553.82.1.el8_10.x86_64 x86_64 GNU/Linux
OS: Red Hat Enterprise Linux 8.10 (Ootpa)
Host glibc: 2.28
Host libstdc++: 6.0.25
/usr/bin/gcc: 8.5.0
/usr/bin/ruby: N/A
glibc: 2.35_2
gcc@12: N/A
gcc: 15.2.0
xorg: N/A

Output of brew doctor

Please note that these warnings are just used to help the Homebrew maintainers
with debugging if you file an issue. If everything you use Homebrew for is
working fine: please don't worry or file an issue; just ignore this. Thanks!

Warning: Your system glibc 2.28 is too old.
We will need to automatically install a newer version.

We recommend updating to a newer version via your distribution's
package manager, upgrading your distribution to the latest version,
or changing distributions.

This is a Tier 2 configuration:
  https://docs.brew.sh/Support-Tiers#tier-2
You can report Tier 2 unrelated issues to Homebrew/* repositories!
Read the above document before opening any issues or PRs.

Description of issue

I am attempting to edit a formula with VS Code by running the following command:

EDITOR=code brew edit wget

However, I get the following message from VS Code:

Command is only available in WSL or inside a Visual Studio Code terminal.

This is because VS Code checks for the presence of either of two environment variables, VSCODE_IPC_HOOK_CLI and VSCODE_CLIENT_COMMAND before sending the contents of the file passed in as stdin to the IPC pipe located at VSCODE_IPC_HOOK_CLI so that it can open on the local VS Code instance.

However, the above message is received instead because it seems that the brew command is clearing the environment before executing code. If you open the code script and modify it to print the contents of the VSCODE_IPC_HOOK_CLI environment variable, you can see it get cleared when doing EDITOR=code brew edit wget as opposed to doing code "$(brew edit wget--print-path)":

1. Open the code script and tell it to print the contents of VSCODE_IPC_HOOK_CLI by adding echo "VSCODE_IPC_HOOK_CLI: $VSCODE_IPC_HOOK_CLI" near the end:

   #!/usr/bin/env sh
   #
   # Copyright (c) Microsoft Corporation. All rights reserved.
   #
   ROOT="$(dirname "$(dirname "$(dirname "$(readlink -f "$0")")")")"
   
   APP_NAME="code"
   VERSION="1.105.0"
   COMMIT="03c265b1adee71ac88f833e065f7bb956b60550a"
   EXEC_NAME="code"
   CLI_SCRIPT="$ROOT/out/server-cli.js"
   echo "VSCODE_IPC_HOOK_CLI: $VSCODE_IPC_HOOK_CLI"
   "$ROOT/node" "$CLI_SCRIPT" "$APP_NAME" "$VERSION" "$COMMIT" "$EXEC_NAME" "$@"
   

2. Try to edit the formula using EDITOR=code brew edit wget:

   $ EDITOR=code brew edit wget
   Editing /home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/w/wget.rb
   VSCODE_IPC_HOOK_CLI: 
   Command is only available in WSL or inside a Visual Studio Code terminal.
   To test your local edits, run:
     brew install --build-from-source --verbose --debug ca-certificates
   

3. Now try editing the formula using code "$(brew edit wget --print-path)":

   $ code "$(brew edit wget --print-path)"
   VSCODE_IPC_HOOK_CLI: /run/user/1000/vscode-ipc-e6cc0bea-7b4e-49d5-8eda-28cde61b60b4.sock
   

It seems that brew is clearing that environment variable here. What I am proposing (similar to this commit) is to add VSCODE_IPC_HOOK_CLI to the list of environment variables that are preserved by brew.

[wheelerlaw]

Opened Homebrew/brew#21026 to solve this.