Skip to content

Conversation

@wheelerlaw
Copy link
Contributor

@wheelerlaw wheelerlaw commented Nov 11, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

More information about the background of this PR can be found in this discussion.

This PR preserves the VSCODE_IPC_HOOK_CLI environment variable when running EDITOR=code brew edit ... so that VS Code can use that environment variable during remote development.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks @wheelerlaw!

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Nov 11, 2025
Merged via the queue into Homebrew:main with commit 2b06715 Nov 11, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants