Skip to content

Fix data race in isStreamHealthy #7619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
neilalexander merged 1 commit into from
Dec 8, 2025
Merged

Fix data race in isStreamHealthy #7619

neilalexander merged 1 commit into from
Dec 8, 2025
+4 −1

Conversation

@MauriceVanVeen
Copy link
Member

@MauriceVanVeen MauriceVanVeen commented Dec 5, 2025 

WARNING: DATA RACE
Write at 0x00c0000bd7c8 by goroutine 68843:
  github.com/nats-io/nats-server/v2/server.(*stream).updateWithAdvisory()
      /home/runner/work/nats-server/nats-server/server/stream.go:2494 +0x1d9e

Previous read at 0x00c0000bd7c8 by goroutine 67092:
  github.com/nats-io/nats-server/v2/server.(*jetStream).isStreamHealthy()
      /home/runner/work/nats-server/nats-server/server/jetstream_cluster.go:640 +0x2ae

Signed-off-by: Maurice van Veen [email protected]

@MauriceVanVeen
Fix data race in isStreamHealthy
30a5bac 
Signed-off-by: Maurice van Veen <[email protected]>
@MauriceVanVeen MauriceVanVeen requested a review from a team as a code owner December 5, 2025 13:05
neilalexander
neilalexander approved these changes Dec 5, 2025
View reviewed changes
Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neilalexander neilalexander merged commit 65bd295 into main Dec 8, 2025
152 of 158 checks passed
@neilalexander neilalexander deleted the maurice/stream-healthy-race branch December 8, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neilalexander neilalexander neilalexander approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MauriceVanVeen @neilalexander