Skip to content

Commit 65bd295

Browse files
Fix data race in isStreamHealthy (#7619)
``` WARNING: DATA RACE Write at 0x00c0000bd7c8 by goroutine 68843: github.com/nats-io/nats-server/v2/server.(*stream).updateWithAdvisory() /home/runner/work/nats-server/nats-server/server/stream.go:2494 +0x1d9e Previous read at 0x00c0000bd7c8 by goroutine 67092: github.com/nats-io/nats-server/v2/server.(*jetStream).isStreamHealthy() /home/runner/work/nats-server/nats-server/server/jetstream_cluster.go:640 +0x2ae ``` Signed-off-by: Maurice van Veen <[email protected]>
2 parents acc0a63 + 30a5bac commit 65bd295

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

server/jetstream_cluster.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -636,8 +636,11 @@ func (js *jetStream) isStreamHealthy(acc *Account, sa *streamAssignment) error {
636636
}
637637

638638
msetNode := mset.raftNode()
639+
mset.cfgMu.RLock()
640+
replicas := mset.cfg.Replicas
641+
mset.cfgMu.RUnlock()
639642
switch {
640-
case mset.cfg.Replicas <= 1:
643+
case replicas <= 1:
641644
return nil // No further checks for R=1 streams
642645

643646
case node == nil:

0 commit comments

Comments
 (0)