Catch failure to open clipboard #2590
Conversation
zadjii-msft
left a comment
zadjii-msft
left a comment
There was a problem hiding this comment.
@DHowett-MSFT we should probably push a hotfix update with this change. Dunno if we have others, but this one definitely
zadjii-msft
added
Product-Terminal
miniksa
left a comment
miniksa
left a comment
There was a problem hiding this comment.
Approved but left unmerged so @DHowett-MSFT can see this and consider for patch release.
|
Yes, we should service. |
|
Thank you @carlos-zamora for addressing this issue so quickly! |
| Clipboard::SetContent(dataPack); | ||
| Clipboard::Flush(); | ||
| } | ||
| CATCH_LOG(); |
There was a problem hiding this comment.
Strange thing is that it still crashes to me (every time I do copy). However if I change CRASH_LOG(); to catch(...) { } then there is no longer a crash.
@DHowett-MSFT Any ETA for the hotfix? The build of Terminal that is in MS Store is pretty much unusable and it's not even possible to downgrade to a previous release, which I was pretty happy with. |
|
🎉 Handy links: |
ghost
mentioned this pull request
Summary of the Pull Request
Unfortunately, we can't necessarily guarantee that you can open the clipboard. It just happens -.-. So, let's catch this error and not crash the Terminal.
References
PR Checklist
Tests added/passedRequires documentation to be updated