Every copyOnSelect action crashes the Terminal now

[JDQuackers]

Environment

Windows build number: Win32NT     10.0.18362.0     Microsoft Windows NT 10.0.18362.0

Windows Terminal version (if applicable): 0.4.2382.0  (installed via Microsoft Store, profiles.json attached)

[profiles.txt](https://github.com/microsoft/terminal/files/3607091/profiles.txt)

Steps to reproduce

With the latest version of Windows Terminal, using the attached profiles.json file with copyOnSelect = True, every time I copy text the Terminal will hang for 1-2 seconds and then crash. After the most recent update to 0.4.2382.0, I enabled copyOnSelect and only saw this crash maybe once a day. Since yesterday (9/11), it happens every time I copy text. No settings changes happened, but I do heavily use the Terminal every day with lots of copy/pasting, so as of yesterday my workflow is severely interrupted

Expected behavior

copyOnSelect adds the selected text to clipboard, and Terminal continues to operate as intended

Actual behavior

As soon as the selection period is over, the Terminal hangs for 1-2 seconds with a spinning cursor, then crashes. No text is copied to the clipboard

Also, here is the Feedback Hub posting: https://aka.ms/AA627yk

[zadjii-msft]

@carlos-zamora Do we have a dupe for this one? Presumably this is different than the last copy->crash bug

[JDQuackers]

Accidentally attached the file within the code block so it didn't attach correctly. Here is with a .txt extension to make Github happy:

profiles.txt

[carlos-zamora]

@carlos-zamora Carlos Zamora FTE Do we have a dupe for this one? Presumably this is different than the last copy->crash bug

I don't see a dup for this. But this came after the copy->crash bugfix. So, potentially related?

[spatiebot]

I can confirm this bug.

[mcpiroman]

Does this happen when you disable copyOnSelect and copy things manually (with right click or shift+ctrl+c or whatever)? It also crashes to me but regardless of copyOnSelect.

In particular, changing this line to catch(...) { } stopped the crash for me:

terminal/src/cascadia/TerminalApp/TerminalPage.cpp

Line 1025 in 125e177

CATCH_LOG();