Automated cherry pick of #7223: Visibility API: propagate manager kubeConfig to visibility API server #7224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuki Iwai <[email protected]>
k8s-ci-robot
added
release-note
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
approved
tenzen-y
commented
Oct 10, 2025
| if features.Enabled(features.VisibilityOnDemand) { | ||
| go func() { | ||
| if err := visibility.CreateAndStartVisibilityServer(ctx, queues); err != nil { | ||
| if err := visibility.CreateAndStartVisibilityServer(ctx, queues, kubeConfig); err != nil { |
Member
Author
There was a problem hiding this comment.
Here is a conflict since the main branch one has enableInternalCertManagement argument.
tenzen-y
commented
Oct 10, 2025
| // CreateAndStartVisibilityServer creates visibility server injecting KueueManager and starts it | ||
| func CreateAndStartVisibilityServer(ctx context.Context, kueueMgr *queue.Manager) error { | ||
| config := newVisibilityServerConfig() | ||
| func CreateAndStartVisibilityServer(ctx context.Context, kueueMgr *queue.Manager, kubeConfig *rest.Config) error { |
Member
Author
There was a problem hiding this comment.
Here is a conflict since the main branch one has enableInternalCertManagement argument.
Member
Author
|
/kind bug |
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
LGTM label has been added. Git tree hash: 59fa10fab142b273e795ef0136f29af555a8dd1d
|
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mimowo, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #7223 on release-0.13.
#7223: Visibility API: propagate manager kubeConfig to visibility API server
For details on the cherry pick process, see the cherry pick requests page.