Skip to content

Conversation

@tenzen-y
Copy link
Member

@tenzen-y tenzen-y commented Oct 10, 2025

What type of PR is this?

/kind bug

What this PR does / why we need it:

The current visibility server generates and uses the visibility server dedicated KubeConfig, which does not have client configurations specified in Config API:

type ClientConnection struct {

After this PR, the manager root KubeConfig are propagated to visibility server and it uses the same KubeConfig as the manager.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Visibility API: Fix a bug that the Config clientConnection is not respected in the visibility server.

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 10, 2025
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2025
@netlify
Copy link

netlify bot commented Oct 10, 2025

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit f09bab9
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/68e8edea74f4560008cf888f
😎 Deploy Preview https://deploy-preview-7223--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 10, 2025
Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍
/lgtm
/approve
/cherrypick release-0.14
/cherrypick release-0.13

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 10, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 696ed2ee8c1a0f3525aa414958305091f7b0cd50

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mimowo, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 63a5681 into kubernetes-sigs:main Oct 10, 2025
23 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.15 milestone Oct 10, 2025
@tenzen-y tenzen-y deleted the use-same-client-config-for-visibility-server branch October 10, 2025 12:02
@tenzen-y
Copy link
Member Author

/cherrypick release-0.14
/cherrypick release-0.13

@k8s-infra-cherrypick-robot
Copy link
Contributor

@tenzen-y: #7223 failed to apply on top of branch "release-0.13":

Applying: Visibility API: propagate manager kubeConfig to visibility API server
Using index info to reconstruct a base tree...
M	cmd/kueue/main.go
M	pkg/visibility/server.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/visibility/server.go
CONFLICT (content): Merge conflict in pkg/visibility/server.go
Auto-merging cmd/kueue/main.go
CONFLICT (content): Merge conflict in cmd/kueue/main.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Visibility API: propagate manager kubeConfig to visibility API server

In response to this:

/cherrypick release-0.14
/cherrypick release-0.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tenzen-y
Copy link
Member Author

/cherrypick release-0.14

@k8s-infra-cherrypick-robot
Copy link
Contributor

@tenzen-y: new pull request created: #7225

In response to this:

/cherrypick release-0.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants