-
Notifications
You must be signed in to change notification settings - Fork 479
Visibility API: propagate manager kubeConfig to visibility API server #7223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visibility API: propagate manager kubeConfig to visibility API server #7223
Conversation
Signed-off-by: Yuki Iwai <[email protected]>
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mimowo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 👍
/lgtm
/approve
/cherrypick release-0.14
/cherrypick release-0.13
|
LGTM label has been added. Git tree hash: 696ed2ee8c1a0f3525aa414958305091f7b0cd50
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mimowo, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherrypick release-0.14 |
|
@tenzen-y: #7223 failed to apply on top of branch "release-0.13": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherrypick release-0.14 |
|
@tenzen-y: new pull request created: #7225 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
The current visibility server generates and uses the visibility server dedicated KubeConfig, which does not have client configurations specified in Config API:
kueue/apis/config/v1beta1/configuration_types.go
Line 381 in 9ac669d
After this PR, the manager root KubeConfig are propagated to visibility server and it uses the same KubeConfig as the manager.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?