Skip to content

fix(inputs.zfs): Avoid panic by handling explicitly empty kstat metrics #17953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skartikey merged 2 commits into from
Nov 7, 2025
Merged

fix(inputs.zfs): Avoid panic by handling explicitly empty kstat metrics #17953

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
daacf5d
fix(inputs.zfs): Avoid panic by handling explicitly empty kstat metrics
srebhan Nov 6, 2025
85abb10
Remove big unused files
srebhan Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20,172 changes: 0 additions & 20,172 deletions plugins/inputs/zfs/testcases/linux/issue_17578/zfs/dbgmsg
View file
Open in desktop

This file was deleted.

65,759 changes: 0 additions & 65,759 deletions plugins/inputs/zfs/testcases/linux/issue_17578/zfs/dbufs
View file
Open in desktop

This file was deleted.

20,172 changes: 0 additions & 20,172 deletions plugins/inputs/zfs/testcases/linux/issue_17578_native_types/zfs/dbgmsg
View file
Open in desktop

This file was deleted.

65,759 changes: 0 additions & 65,759 deletions plugins/inputs/zfs/testcases/linux/issue_17578_native_types/zfs/dbufs
View file
Open in desktop

This file was deleted.

86 changes: 86 additions & 0 deletions plugins/inputs/zfs/testcases/linux/issue_17952/expected.out
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 6 additions & 0 deletions plugins/inputs/zfs/testcases/linux/issue_17952/telegraf.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
[[inputs.zfs]]
interval="300s"
kstatMetrics = [""]
poolMetrics = true
datasetMetrics = false
useNativeTypes = true
22 changes: 22 additions & 0 deletions plugins/inputs/zfs/testcases/linux/issue_17952/zfs/abdstats
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
15 1 0x01 20 5440 2743234184 1351143840456489
name type data
struct_size 4 43472448
linear_cnt 4 92773
linear_data_size 4 56781824
scatter_cnt 4 18446744073706144377
scatter_data_size 4 18446743951282640896
scatter_chunk_waste 4 89159680
scatter_order_0 4 147066
scatter_order_1 4 129391
scatter_order_2 4 51404
scatter_order_3 4 45157
scatter_order_4 4 37655
scatter_order_5 4 33768
scatter_order_6 4 1973
scatter_order_7 4 107
scatter_order_8 4 6
scatter_order_9 4 0
scatter_page_multi_chunk 4 71092
scatter_page_multi_zone 4 0
scatter_page_alloc_retry 4 0
scatter_sg_table_retry 4 0
149 changes: 149 additions & 0 deletions plugins/inputs/zfs/testcases/linux/issue_17952/zfs/arcstats
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,149 @@
22 1 0x01 147 39984 2746799574 1351143854159630
name type data
hits 4 33266704081
iohits 4 1992434
misses 4 30882817
demand_data_hits 4 5821681723
demand_data_iohits 4 129861
demand_data_misses 4 3518537
demand_metadata_hits 4 27412286726
demand_metadata_iohits 4 352462
demand_metadata_misses 4 4959691
prefetch_data_hits 4 1263505
prefetch_data_iohits 4 18697
prefetch_data_misses 4 7231097
prefetch_metadata_hits 4 31472127
prefetch_metadata_iohits 4 1491414
prefetch_metadata_misses 4 15173492
mru_hits 4 349427845
mru_ghost_hits 4 742728
mfu_hits 4 32917276236
mfu_ghost_hits 4 2111782
uncached_hits 4 0
deleted 4 33203762
mutex_miss 4 6768
access_skip 4 766
evict_skip 4 8010764
evict_not_enough 4 3052
evict_l2_cached 4 0
evict_l2_eligible 4 2039006768128
evict_l2_eligible_mfu 4 597042593792
evict_l2_eligible_mru 4 1441964174336
evict_l2_ineligible 4 753355764736
evict_l2_skip 4 0
hash_elements 4 622527
hash_elements_max 4 622527
hash_collisions 4 13041366
hash_chains 4 41904
hash_chain_max 4 7
meta 4 1353044739
pd 4 1318937075
pm 4 957173313
c 4 15590628496
c_min 4 1047890560
c_max 4 32458756096
size 4 14960038920
compressed_size 4 11425281024
uncompressed_size 4 22570664448
overhead_size 4 1640898560
hdr_size 4 151816784
data_size 4 10482880000
metadata_size 4 2583299584
dbuf_size 4 301577840
dnode_size 4 1104341896
bonus_size 4 246963136
anon_size 4 7425024
anon_data 4 561152
anon_metadata 4 6863872
anon_evictable_data 4 0
anon_evictable_metadata 4 0
mru_size 4 3633208320
mru_data 4 2740104192
mru_metadata 4 893104128
mru_evictable_data 4 2661687808
mru_evictable_metadata 4 324192768
mru_ghost_size 4 7816084480
mru_ghost_data 4 2746446848
mru_ghost_metadata 4 5069637632
mru_ghost_evictable_data 4 2746446848
mru_ghost_evictable_metadata 4 5069637632
mfu_size 4 9425546240
mfu_data 4 7742214656
mfu_metadata 4 1683331584
mfu_evictable_data 4 7483030528
mfu_evictable_metadata 4 393818112
mfu_ghost_size 4 2053218816
mfu_ghost_data 4 2053078528
mfu_ghost_metadata 4 140288
mfu_ghost_evictable_data 4 2053078528
mfu_ghost_evictable_metadata 4 140288
uncached_size 4 0
uncached_data 4 0
uncached_metadata 4 0
uncached_evictable_data 4 0
uncached_evictable_metadata 4 0
l2_hits 4 0
l2_misses 4 0
l2_prefetch_asize 4 0
l2_mru_asize 4 0
l2_mfu_asize 4 0
l2_bufc_data_asize 4 0
l2_bufc_metadata_asize 4 0
l2_feeds 4 0
l2_rw_clash 4 0
l2_read_bytes 4 0
l2_write_bytes 4 0
l2_writes_sent 4 0
l2_writes_done 4 0
l2_writes_error 4 0
l2_writes_lock_retry 4 0
l2_evict_lock_retry 4 0
l2_evict_reading 4 0
l2_evict_l1cached 4 0
l2_free_on_write 4 0
l2_abort_lowmem 4 0
l2_cksum_bad 4 0
l2_io_error 4 0
l2_size 4 0
l2_asize 4 0
l2_hdr_size 4 0
l2_log_blk_writes 4 0
l2_log_blk_avg_asize 4 0
l2_log_blk_asize 4 0
l2_log_blk_count 4 0
l2_data_to_meta_ratio 4 0
l2_rebuild_success 4 0
l2_rebuild_unsupported 4 0
l2_rebuild_io_errors 4 0
l2_rebuild_dh_errors 4 0
l2_rebuild_cksum_lb_errors 4 0
l2_rebuild_lowmem 4 0
l2_rebuild_size 4 0
l2_rebuild_asize 4 0
l2_rebuild_bufs 4 0
l2_rebuild_bufs_precached 4 0
l2_rebuild_log_blks 4 0
memory_throttle_count 4 0
memory_direct_count 4 21360
memory_indirect_count 4 3213452
memory_all_bytes 4 33532497920
memory_free_bytes 4 5194235904
memory_available_bytes 3 3970557824
arc_no_grow 4 0
arc_tempreserve 4 0
arc_loaned_bytes 4 0
arc_prune 4 2926904
arc_meta_used 4 4387999240
arc_dnode_limit 4 3245875609
async_upgrade_sync 4 143414
predictive_prefetch 4 32998184
demand_hit_predictive_prefetch 4 10846561
demand_iohit_predictive_prefetch 4 221984
prescient_prefetch 4 23652148
demand_hit_prescient_prefetch 4 15045228
demand_iohit_prescient_prefetch 4 232315
arc_need_free 4 0
arc_sys_free 4 1223678080
arc_raw_size 4 0
cached_only_in_progress 4 0
abd_chunk_waste_size 4 89159680
12 changes: 12 additions & 0 deletions plugins/inputs/zfs/testcases/linux/issue_17952/zfs/brtstats
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
13 1 0x01 10 2720 2742619344 1351143840335709
name type data
addref_entry_not_on_disk 4 800
addref_entry_on_disk 4 11
decref_entry_in_memory 4 398
decref_entry_loaded_from_disk 4 73347
decref_entry_not_in_memory 4 99677
decref_entry_read_lost_race 4 4
decref_entry_still_referenced 4 11
decref_free_data_later 4 73343
decref_free_data_now 4 395
decref_no_entry 4 26326
18 changes: 18 additions & 0 deletions plugins/inputs/zfs/testcases/linux/issue_17952/zfs/chksum_bench
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
30 0 0x01 -1 0 2870392640 1351144218354647
implementation 1k 4k 16k 64k 256k 1m 4m 16m
edonr-generic 867 1687 1910 1946 0 1940 1943 1849
skein-generic 638 735 746 766 0 767 771 770
sha256-generic 248 273 280 271 0 282 279 280
sha256-x64 162 181 228 360 0 360 356 361
sha256-ssse3 169 382 436 437 0 442 441 442
sha256-avx 169 186 194 193 0 197 196 197
sha256-avx2 381 466 498 510 0 477 507 504
sha256-shani 488 1486 1869 1894 0 1972 983 1974
sha512-generic 355 421 439 442 0 426 418 409
sha512-x64 211 178 552 564 0 570 568 571
sha512-avx 239 284 302 305 0 304 306 304
sha512-avx2 317 425 635 723 0 731 727 733
blake3-generic 296 315 319 319 0 320 319 319
blake3-sse2 296 1301 1429 1492 0 1460 1464 1426
blake3-sse41 309 1413 1570 1624 0 1619 1603 1542
blake3-avx2 312 1831 3071 3409 0 3313 3258 3105
46 changes: 46 additions & 0 deletions plugins/inputs/zfs/testcases/linux/issue_17952/zfs/dbufstats
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
25 1 0x01 44 11968 2747596084 1351144218183457
name type data
cache_count 4 10919
cache_size_bytes 4 448766184
cache_size_bytes_max 4 1401984224
cache_target_bytes 4 487207140
cache_lowater_bytes 4 438486426
cache_hiwater_bytes 4 535927854
cache_total_evicts 4 132805870
cache_level_0 4 10740
cache_level_1 4 171
cache_level_2 4 0
cache_level_3 4 0
cache_level_4 4 0
cache_level_5 4 8
cache_level_6 4 0
cache_level_7 4 0
cache_level_8 4 0
cache_level_9 4 0
cache_level_10 4 0
cache_level_11 4 0
cache_level_0_bytes 4 425517288
cache_level_1_bytes 4 22200320
cache_level_2_bytes 4 0
cache_level_3_bytes 4 0
cache_level_4_bytes 4 0
cache_level_5_bytes 4 1048576
cache_level_6_bytes 4 0
cache_level_7_bytes 4 0
cache_level_8_bytes 4 0
cache_level_9_bytes 4 0
cache_level_10_bytes 4 0
cache_level_11_bytes 4 0
hash_hits 4 41537759570
hash_misses 4 10846135
hash_collisions 4 968851200
hash_elements 4 70214
hash_chains 4 4248
hash_chain_max 4 7
hash_insert_race 4 878186
hash_table_count 4 524288
hash_mutex_count 4 8192
metadata_cache_count 4 3822
metadata_cache_size_bytes 4 266283520
metadata_cache_size_bytes_max 4 289494016
metadata_cache_overflow 4 7558797806
15 changes: 15 additions & 0 deletions plugins/inputs/zfs/testcases/linux/issue_17952/zfs/dmu_tx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
18 1 0x01 13 3536 2743356034 1351143854108050
name type data
dmu_tx_assigned 4 588581682
dmu_tx_delay 4 0
dmu_tx_error 4 0
dmu_tx_suspended 4 0
dmu_tx_group 4 16
dmu_tx_memory_reserve 4 0
dmu_tx_memory_reclaim 4 0
dmu_tx_dirty_throttle 4 1
dmu_tx_dirty_delay 4 1834959
dmu_tx_dirty_over_max 4 0
dmu_tx_dirty_frees_delay 4 0
dmu_tx_wrlog_delay 4 0
dmu_tx_quota 4 0
30 changes: 30 additions & 0 deletions plugins/inputs/zfs/testcases/linux/issue_17952/zfs/dnodestats
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
16 1 0x01 28 7616 2743346584 1351143854024270
name type data
dnode_hold_dbuf_hold 4 0
dnode_hold_dbuf_read 4 0
dnode_hold_alloc_hits 4 13035797509
dnode_hold_alloc_misses 4 31842761
dnode_hold_alloc_interior 4 369768
dnode_hold_alloc_lock_retry 4 11053
dnode_hold_alloc_lock_misses 4 168
dnode_hold_alloc_type_none 4 440815
dnode_hold_free_hits 4 30532019
dnode_hold_free_misses 4 2133905
dnode_hold_free_lock_misses 4 2
dnode_hold_free_lock_retry 4 58
dnode_hold_free_overflow 4 0
dnode_hold_free_refcount 4 0
dnode_free_interior_lock_retry 4 0
dnode_allocate 4 30532079
dnode_reallocate 4 2948
dnode_buf_evict 4 59374210
dnode_alloc_next_chunk 4 250714
dnode_alloc_race 4 0
dnode_alloc_next_block 4 3262
dnode_move_invalid 4 0
dnode_move_recheck1 4 0
dnode_move_recheck2 4 0
dnode_move_special 4 0
dnode_move_handle 4 0
dnode_move_rwlock 4 0
dnode_move_active 4 0
9 changes: 9 additions & 0 deletions plugins/inputs/zfs/testcases/linux/issue_17952/zfs/fletcher_4_bench
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
5 0 0x01 -1 0 2742337774 1351143840039079
implementation native byteswap
scalar 7994099204 5539228737
superscalar 8342059309 6653242705
superscalar4 11054417668 7765432075
sse2 15794929344 8277597144
ssse3 15663538418 13131513818
avx2 21357557858 21350310084
fastest avx2 avx2
7 changes: 7 additions & 0 deletions plugins/inputs/zfs/testcases/linux/issue_17952/zfs/fm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
11 1 0x01 5 1360 2742556064 1351143840229379
name type data
erpt-dropped 4 0
erpt-set-failed 4 0
fmri-set-failed 4 0
payload-set-failed 4 0
erpt-duplicates 4 0
1 change: 1 addition & 0 deletions plugins/inputs/zfs/testcases/linux/issue_17952/zfs/import_progress
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
pool_guid load_state multihost_secs max_txg pool_name notes
6 changes: 6 additions & 0 deletions plugins/inputs/zfs/testcases/linux/issue_17952/zfs/metaslab_stats
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
12 1 0x01 4 1088 2742595114 1351143840280929
name type data
trace_over_limit 4 0
reload_tree 4 80213
too_many_tries 4 281709
try_hard 4 1499634
33 changes: 33 additions & 0 deletions plugins/inputs/zfs/testcases/linux/issue_17952/zfs/simd
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
kfpu_allowed 1
kfpu 0
kfpu_internal 1
__kernel_fpu 0
sse 1
sse2 1
sse3 1
ssse3 1
sse41 1
sse42 1
avx 1
avx2 1
avx512f 0
avx512cd 0
avx512er 0
avx512pf 0
avx512bw 0
avx512dq 0
avx512vl 0
avx512ifma 0
avx512vbmi 0
ymm 1
zmm 0
bmi1 1
bmi2 1
aes 1
pclmulqdq 1
movbe 1
osxsave 1
xsaves 0
xsaveopt 1
xsave 1
fxsr 1
19 changes: 19 additions & 0 deletions plugins/inputs/zfs/testcases/linux/issue_17952/zfs/store/ddt_stats_blake3
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
291 1 0x01 17 4624 44334865167 1351144220553207
name type data
lookup 4 0
lookup_new 4 0
lookup_existing 4 0
lookup_live_hit 4 0
lookup_live_wait 4 0
lookup_live_miss 4 0
lookup_log_hit 4 0
lookup_log_active_hit 4 0
lookup_log_flushing_hit 4 0
lookup_log_miss 4 0
lookup_stored_hit 4 0
lookup_stored_miss 4 0
log_active_entries 4 0
log_flushing_entries 4 0
log_ingest_rate 2 0
log_flush_rate 2 0
log_flush_time_rate 2 0
Loading
Loading