fix(inputs.zfs): Avoid panic by handling explicitly empty kstat metrics #17953
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Setting the
kstatMetricsoption explicitly to an empty string (i.e.kstatMetrics = [""]) prevents the default collection of those metrics (as the list is not empty) which might be desirable in some cases. However, the current code uses the entries literally for filenames and will panic.This PR handles empty entries, i.e. explicitly disabling kstat metrics, correctly and moves code to an
Initfunction to improve readability.Checklist
Related issues
resolves #17952