Skip to content

Accommodate the "dataset_slug" field in triggers #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jharley merged 1 commit into from
Jul 23, 2025
Merged

Accommodate the "dataset_slug" field in triggers #720

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions client/trigger.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,9 @@ var _ Triggers = (*triggers)(nil)
type Trigger struct {
ID string `json:"id,omitempty"`

// DatasetSlug is the slug of the dataset this trigger belongs to. For environment-wide
// triggers, this will be [EnvironmentWideSlug].
DatasetSlug string `json:"dataset_slug,omitempty"`
// Name of the trigger. This field is required.
Name string `json:"name"`
// Description is displayed on the triggers page.
Expand Down
4 changes: 3 additions & 1 deletion client/trigger_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ func TestTriggers(t *testing.T) {
require.NoError(t, err)
assert.NotNil(t, trigger.ID)

data.DatasetSlug = trigger.DatasetSlug
// copy IDs before asserting equality
data.ID = trigger.ID
data.QueryID = trigger.QueryID
Expand Down Expand Up @@ -270,6 +271,7 @@ func TestTriggersWithBaselineDetails(t *testing.T) {
require.NoError(t, err)
assert.NotNil(t, trigger.ID)

data.DatasetSlug = trigger.DatasetSlug
// copy IDs before asserting equality
data.ID = trigger.ID
data.QueryID = trigger.QueryID
Expand Down Expand Up @@ -314,7 +316,6 @@ func TestTriggersWithBaselineDetails(t *testing.T) {
assert.Equal(t, trigger.BaselineDetails.Type, result.BaselineDetails.Type)
assert.Equal(t, trigger.BaselineDetails.OffsetMinutes, result.BaselineDetails.OffsetMinutes)
})

}

func TestTriggersEnvironmentWide(t *testing.T) {
Expand Down Expand Up @@ -365,6 +366,7 @@ func TestTriggersEnvironmentWide(t *testing.T) {
require.NoError(t, err)
assert.NotNil(t, trigger.ID)

data.DatasetSlug = trigger.DatasetSlug
// copy IDs before asserting equality
data.ID = trigger.ID
data.QueryID = trigger.QueryID
Expand Down