Accommodate the "dataset_slug" field in triggers #720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seh
commented
Jul 22, 2025
Augment the Honeycomb API client in the "client" package to convey the "dataset_slug" field for triggers. When querying for triggers at the environment level, the API returns all triggers within the environment—including those tied to a particular dataset. Clients can read the populated "dataset_slug" field to distinguish which triggers are tied to which dataset and those that sit at the environment level, above and separate from any particular dataset. Note that this change does not yet cover the Terraform provider's publishing to or querying of data from the Honeycomb API as exposed through its Terraform resources and data sources.
seh
force-pushed
the
include-dataset-slug-in-triggers
branch
from
11d708e to
d0a7492
Compare
jharley
approved these changes
Jul 23, 2025
Collaborator
jharley
left a comment
jharley
left a comment
There was a problem hiding this comment.
Thanks for fixing this oversight on our part! ✨
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Augment the Honeycomb API client in the
clientpackage to convey the "dataset_slug" field for triggers. When querying for triggers at the environment level, the API returns all triggers within the environment—including those tied to a particular dataset. Clients can read the populated "dataset_slug" field to distinguish which triggers are tied to which dataset and those that sit at the environment level, above and separate from any particular dataset.Note that this change does not yet cover the Terraform provider's publishing to or querying of data from the Honeycomb API as exposed through its Terraform resources and data sources.