Skip to content

Conversation

@NisanthanNanthakumar
Copy link
Contributor

Objective:

Deletes ProjectUserDetailsEndpoint GET and DELETE endpoints.

We have not had a request to both these endpoints in the past 365 days. Redash query here.

Prior to merging, we will need to let the support team know.

@NisanthanNanthakumar NisanthanNanthakumar requested a review from a team as a code owner November 1, 2023 12:29
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 1, 2023
@codecov
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #59180 (35d18f8) into master (c2e0590) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #59180      +/-   ##
==========================================
- Coverage   80.77%   80.77%   -0.01%     
==========================================
  Files        5164     5163       -1     
  Lines      225813   225785      -28     
  Branches    37995    37993       -2     
==========================================
- Hits       182403   182372      -31     
- Misses      37883    37885       +2     
- Partials     5527     5528       +1     
Files Coverage Δ
src/sentry/api/urls.py 100.00% <ø> (ø)

... and 10 files with indirect coverage changes

@JoshFerge
Copy link
Member

looks like there are some test failures.

@NisanthanNanthakumar NisanthanNanthakumar force-pushed the eventuser/delete-ProjectUserDetailsEndpoint branch from c111eed to 35d18f8 Compare November 4, 2023 02:06
@NisanthanNanthakumar NisanthanNanthakumar linked an issue Nov 4, 2023 that may be closed by this pull request
Copy link
Contributor

@schew2381 schew2381 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just be sure to let support know just in case

@NisanthanNanthakumar
Copy link
Contributor Author

@schew2381 yep! already started the conversation last week

@NisanthanNanthakumar NisanthanNanthakumar merged commit 579a829 into master Nov 8, 2023
@NisanthanNanthakumar NisanthanNanthakumar deleted the eventuser/delete-ProjectUserDetailsEndpoint branch November 8, 2023 23:10
@github-actions github-actions bot locked and limited conversation to collaborators Nov 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Delete ProjectUserDetailsEndpoint

4 participants