Skip to content

fix: event notification calls missing for Build Success and Cd Deployment Success for helm type #2898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vikramdevtron merged 6 commits into from
Feb 1, 2023
Merged

fix: event notification calls missing for Build Success and Cd Deployment Success for helm type #2898

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b2534a4
ci success event fix
vikramdevtron Jan 25, 2023
b4df243
added cd success event notification call
vikramdevtron Jan 25, 2023
867b0ee
merged with main
vikramdevtron Jan 31, 2023
05525c3
Merge branch 'main' into hotfix-ci-success-event
vikramdevtron Jan 31, 2023
af98285
Merge branch 'main' into hotfix-ci-success-event
vikramdevtron Feb 1, 2023
0535caf
Merge branch 'main' into hotfix-ci-success-event
vikramdevtron Feb 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/app/AppService.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,7 @@ type AppService interface {
MarkImageScanDeployed(appId int, envId int, imageDigest string, clusterId int) error
GetChartRepoName(gitRepoUrl string) string
UpdateDeploymentStatusForGitOpsCdPipelines(app *v1alpha1.Application, statusTime time.Time) (bool, bool, error)
WriteCDSuccessEvent(appId int, envId int, override *chartConfig.PipelineOverride)
}

func NewAppService(
Expand Down
1 change: 1 addition & 0 deletions pkg/pipeline/CdHandler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,6 +317,7 @@ func (impl *CdHandlerImpl) CheckHelmAppStatusPeriodicallyAndUpdateInDb(timeForDe
}
impl.Logger.Infow("updating workflow runner status for helm app", "cdWf", cdWf)
if cdWf.Status == application.Healthy {
go impl.appService.WriteCDSuccessEvent(pipelineOverride.Pipeline.AppId, pipelineOverride.Pipeline.EnvironmentId, pipelineOverride)
err = impl.workflowDagExecutor.HandleDeploymentSuccessEvent("", pipelineOverride.Id)
if err != nil {
impl.Logger.Errorw("error on handling deployment success event", "cdWf", cdWf, "err", err)
Expand Down
1 change: 1 addition & 0 deletions pkg/pipeline/WebhookService.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,7 @@ func (impl WebhookServiceImpl) HandleCiSuccessEvent(ciPipelineId int, request *C
}
}
ciArtifactArr = append(ciArtifactArr, artifact)
go impl.WriteCISuccessEvent(request, pipeline, artifact)
isCiManual := true
if request.UserId == 1 {
impl.logger.Debugw("Trigger (auto) by system user", "userId", request.UserId)
Expand Down