Skip to content

Conversation

@vikramdevtron
Copy link
Contributor

@vikramdevtron vikramdevtron commented Jan 25, 2023

Description

Event notification calls missing for Build Success and Cd Deployment Success for helm type

Fixes #

How Has This Been Tested?

  • Helm deployment type devtron apps success event
  • Ci build success event

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


@vikramdevtron vikramdevtron self-assigned this Jan 25, 2023
kartik-579
kartik-579 previously approved these changes Jan 25, 2023
@gitguardian
Copy link

gitguardian bot commented Feb 1, 2023

⚠️ GitGuardian has uncovered 5 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
141558 Generic High Entropy Secret 867b0ee scripts/devtron-reference-helm-charts/deployment-chart_1-1-0/env-values.yaml View secret
141558 Generic High Entropy Secret 867b0ee scripts/devtron-reference-helm-charts/reference-chart_4-17-0/env-values.yaml View secret
2763127 Generic High Entropy Secret 867b0ee scripts/devtron-reference-helm-charts/deployment-chart_1-1-0/secrets-test-values.yaml View secret
2763127 Generic High Entropy Secret 867b0ee scripts/devtron-reference-helm-charts/reference-chart_4-17-0/secrets-test-values.yaml View secret
5236769 Generic High Entropy Secret 867b0ee scripts/devtron-reference-helm-charts/deployment-chart_1-1-0/test-values.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vikramdevtron vikramdevtron merged commit 766523c into main Feb 1, 2023
@vikramdevtron vikramdevtron deleted the hotfix-ci-success-event branch February 1, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants