[ty] Suppress false positives when dataclasses.dataclass(...)(cls) is called imperatively
#21729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is called imperatively
Diagnostic diff on typing conformance testsNo changes detected when running ty on typing conformance tests ✅ |
AlexWaygood
commented
Dec 1, 2025
Comment on lines
+1500
to
+1508
| @dataclass_transform(kw_only_default=True) | ||
| def sequence3(cls: type[U]) -> type[U]: | ||
| # TODO: should reveal `type[U@sequence3]` | ||
| return reveal_type(dataclass(cls)) # revealed: Unknown | ||
|
|
||
| @dataclass_transform(kw_only_default=True) | ||
| def sequence4(cls: type) -> type: | ||
| # TODO: should reveal `type` | ||
| return reveal_type(dataclass(cls)) # revealed: Unknown |
Member
Author
There was a problem hiding this comment.
these Unknowns are just us failing to solve the generic overloads in typeshed's signature for dataclasses.dataclass, I think
|
|
| Lint rule | Added | Removed | Changed |
|---|---|---|---|
call-non-callable |
0 | 8 | 0 |
unused-ignore-comment |
2 | 0 | 0 |
unsupported-base |
1 | 0 | 0 |
| Total | 3 | 8 | 0 |
AlexWaygood
force-pushed
the
alex/callable-dataclass
branch
from
0594850 to
8dfa0d0
Compare
AlexWaygood
requested review from
carljm,
dcreager and
sharkdp
as code owners
dcreager
added a commit
that referenced
this pull request
Dec 3, 2025
* origin/main: [ty] Improve `@override`, `@final` and Liskov checks in cases where there are multiple reachable definitions (#21767) [ty] Extend `invalid-explicit-override` to also cover properties decorated with `@override` that do not override anything (#21756) [ty] Enable LRU collection for parsed module (#21749) [ty] Support typevar-specialized dynamic types in generic type aliases (#21730) Add token based `parenthesized_ranges` implementation (#21738) [ty] Default-specialization of generic type aliases (#21765) [ty] Suppress false positives when `dataclasses.dataclass(...)(cls)` is called imperatively (#21729) [syntax-error] Default type parameter followed by non-default type parameter (#21657) new module for parsing ranged suppressions (#21441) [ty] `type[T]` is assignable to an inferable typevar (#21766) Fix syntax error false positives for `await` outside functions (#21763) [ty] Improve diagnostics for unsupported comparison operations (#21737) Move `Token`, `TokenKind` and `Tokens` to `ruff-python-ast` (#21760) [ty] Don't confuse multiple occurrences of `typing.Self` when binding bound methods (#21754) Use our org-wide Renovate preset (#21759) Delete `my-script.py` (#21751) [ty] Move `all_members`, and related types/routines, out of `ide_support.rs` (#21695)
dcreager
added a commit
that referenced
this pull request
Dec 3, 2025
* origin/main: [ty] Reachability constraints: minor documentation fixes (#21774) [ty] Fix non-determinism in `ConstraintSet.specialize_constrained` (#21744) [ty] Improve `@override`, `@final` and Liskov checks in cases where there are multiple reachable definitions (#21767) [ty] Extend `invalid-explicit-override` to also cover properties decorated with `@override` that do not override anything (#21756) [ty] Enable LRU collection for parsed module (#21749) [ty] Support typevar-specialized dynamic types in generic type aliases (#21730) Add token based `parenthesized_ranges` implementation (#21738) [ty] Default-specialization of generic type aliases (#21765) [ty] Suppress false positives when `dataclasses.dataclass(...)(cls)` is called imperatively (#21729) [syntax-error] Default type parameter followed by non-default type parameter (#21657)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes astral-sh/ty#1705