[Improve][Transform-V2] SQL transform EXTRACT function support more fields #9342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hisoka-X
changed the title
Hisoka-X
changed the title
Hisoka-X
reviewed
May 22, 2025
Comment on lines
339
to
346
| if (extract.getExpression() instanceof DateTimeLiteralExpression) { | ||
| DateTimeLiteralExpression dateTimeLiteralExpression = | ||
| (DateTimeLiteralExpression) extract.getExpression(); | ||
| String value = dateTimeLiteralExpression.getValue(); | ||
| if (value.startsWith("'") && value.endsWith("'")) { | ||
| value = value.substring(1, value.length() - 1); | ||
| } | ||
| functionArgs.add(LocalDateTime.parse(value)); |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the SQL EXTRACT function to support more temporal units (e.g., week, ISO year, epoch, microseconds, millennium) and adds literal parsing for all four datetime types, including timezones.
- Extended
DateTimeFunction.extractwith new cases andOffsetDateTimesupport - Added
computeDateTimeLiteralExpressioninZetaSQLFunctionfor TIMESTAMPTZ - Created
ExtractFunctionTestcovering LocalDateTime, LocalDate, Sunday behavior, and literal expressions - Updated English and Chinese docs to list all supported fields and literal types
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| seatunnel-transforms-v2/src/main/java/org/apache/seatunnel/transform/sql/zeta/functions/DateTimeFunction.java | Extend EXTRACT implementation with new units and OffsetDateTime handling |
| seatunnel-transforms-v2/src/main/java/org/apache/seatunnel/transform/sql/zeta/ZetaSQLFunction.java | Add DateTimeLiteralExpression parsing for TIMESTAMPTZ |
| seatunnel-transforms-v2/src/test/java/org/apache/seatunnel/transform/sql/zeta/ExtractFunctionTest.java | New tests for EXTRACT on datetime, date, Sunday, and literals |
| docs/en/transform-v2/sql-functions.md | Document new EXTRACT units and literal support |
| docs/zh/transform-v2/sql-functions.md | Document new EXTRACT units and literal support |
Comments suppressed due to low confidence (3)
seatunnel-transforms-v2/src/main/java/org/apache/seatunnel/transform/sql/zeta/functions/DateTimeFunction.java:466
- There is no unit test verifying
EXTRACT(WEEK FROM ...). Please add a test case inExtractFunctionTestto cover ISO week extraction.
case "WEEK":
seatunnel-transforms-v2/src/main/java/org/apache/seatunnel/transform/sql/zeta/functions/DateTimeFunction.java:533
- The new
ISOYEARunit lacks a corresponding test. Add a test inExtractFunctionTestto ensure ISO week-based year extraction is correct.
case "ISOYEAR":
seatunnel-transforms-v2/src/main/java/org/apache/seatunnel/transform/sql/zeta/functions/DateTimeFunction.java:468
- The code calls
get(...)on thedatetimeobject without casting it to aTemporalAccessorsubtype; this will not compile. CastdatetimetoLocalDate,LocalDateTime, orOffsetDateTime(and extract the date component if needed) before callingget(WeekFields.ISO.weekOfYear()).
return datetime.get(WeekFields.ISO.weekOfYear());
| return date.get(WeekFields.ISO.weekBasedYear()); | ||
| } | ||
| break; | ||
| case "MILLENNIUM": |
There was a problem hiding this comment.
OffsetDateTime is not handled in the MILLENNIUM case. Add an instanceof OffsetDateTime branch similar to other units so timestamptz values can return the correct millennium.
| - `ISOYEAR`: The ISO 8601 week-numbering year | ||
| - `MICROSECONDS`: The seconds field, including fractional parts, multiplied by 1,000,000 | ||
| - `MILLENNIUM`: The millennium; for interval values, the year field divided by 1000 | ||
| - `MILLISECONDS`: The seconds field, including fractional parts, multiplied by 1,000 |
There was a problem hiding this comment.
The docs list the field as MILLISECONDS (plural), but the implementation uses MILLISECOND (singular). Align the documentation with the actual field name or update the code to accept the plural form.
Suggested change
| - `MILLISECONDS`: The seconds field, including fractional parts, multiplied by 1,000 | |
| - `MILLISECOND`: The seconds field, including fractional parts, multiplied by 1,000 |
hailin0
approved these changes
May 27, 2025
dybyte
pushed a commit
to dybyte/seatunnel
that referenced
this pull request
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #9325
Purpose of this pull request
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide