-
Notifications
You must be signed in to change notification settings - Fork 327
[AGM-2665] Add AdGuard Mini for Mac section #798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Add AdGuard Mini for Mac section: updated screenshots and instructions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other comments (19)
- docs/adguard-mini-for-mac/features/features.md (20-20) The description for the Settings section (line 20) appears to be incorrect as it's identical to the About section's description (line 28). The Settings section should have a description that accurately reflects its purpose, such as configuration options for the application.
- docs/adguard-mini-for-mac/solving-problems/logs.md (20-20) There's inconsistency in the email addresses for sending logs. Line 20 mentions sending logs to [email protected], while lines 29-30 instruct to send them to [email protected]. Please clarify which email address users should use.
- docs/adguard-mini-for-mac/solving-problems/rule-limit.md (25-25) The document states 'This makes a total of 900,000 filtering rules' but doesn't show how this number is calculated. For clarity, consider adding the calculation: 6 content blockers × 150,000 rules = 900,000 rules total.
- docs/adguard-mini-for-mac/features/toolbar-menu.md (28-32) The Block element section would be more helpful with additional information about what happens after an element is blocked. Does it stay blocked permanently? Can the action be undone? Where can users manage their blocked elements?
- docs/adguard-mini-for-mac/features/safari-protection.md (20-22) Consider adding descriptions for what each of the protection screen images is showing. Currently, they're labeled as 'part one' and 'part two' without explaining what specific settings or features are visible in each image.
- docs/adguard-mini-for-mac/features/toolbar-menu.md (24-26) The description for the Protection option could be more specific about what happens when protection is turned off for a website. Consider clarifying that this adds the site to an allowlist/exceptions list (if that's the case).
-
docs/adguard-mini-for-mac/features/settings/settings.md (14-14)
There's a typo in the description of Filters.
Different filters that allow you to customize your ad blocking experience - docs/adguard-mini-for-mac/features/support.md (22-22) The alt text for the second image ('Support tab') should be more descriptive since it's showing the contact support screen. Consider changing it to 'Contact support screen' or something similar for better accessibility.
-
docs/adguard-mini-for-mac/features/support.md (30-30)
Missing article before 'review' in the Rate app description.
Takes you to the App Store screen where you can leave a review on AdGuard Mini -
docs/adguard-mini-for-mac/solving-problems/private-sonoma.md (8-8)
The info box is missing a period at the end of the sentence.
This article is about AdGuard Mini for Mac, which safeguards only your Safari browser. To protect your Mac entirely, [download the AdGuard app](https://agrd.io/download-kb-adblock). -
docs/adguard-mini-for-mac/solving-problems/ads-not-blocked.md (25-25)
There's an issue with the image markdown. The asterisk in `*mobile` appears to be a typo in the alt text.
 -
docs/adguard-mini-for-mac/solving-problems/ads-not-blocked.md (12-12)
There's an inconsistency in product naming. The document is about 'AdGuard Mini for Mac' but this line refers to 'AdGuard for Safari'. Consider updating for consistency.
In some cases, filtering may not work and ads may still be displayed even though AdGuard Mini and the proper filters are enabled. This usually happens when something goes wrong with filter updates due to Safari bugs. -
docs/adguard-mini-for-mac/features/settings/content-blockers/_category_.json (1-6)
This file is missing a newline at the end. It's a good practice to ensure all text files end with a newline character to avoid issues with certain tools and to follow common coding standards.
{ "position": 3, "label": "Safari extensions", "collapsible": true, "collapsed": true } -
docs/adguard-mini-for-mac/extensions.md (45-45)
There's a typo in this sentence - 'that' is repeated.
*AdGuard Other* applies rules from filters that don't fall under the above-mentioned categories and that are located in *Filters* → *Other*: *Filter unblocking search ads and self-promotion*, *AdGuard DNS filter*, and *AdGuard Experimental filter*. -
docs/adguard-mini-for-mac/features/settings/content-blockers/content-blockers.md (22-22)
There's a grammatical error in this sentence.
You can manage enabled filters in *Settings* → *Filters*. In *Safari extensions* section, you can only see the list of enabled filters and the number of enabled rules. - docs/adguard-mini-for-mac/installation.md (32-32) There's a typo in the image alt text: 'Oopen settings' should be 'Open settings'
- docs/adguard-mini-for-mac/installation.md (28-28) Several image alt texts have an incorrect '*mobile' suffix which should be removed (appears on lines 28, 32, 36, 40, and 44)
- docs/adguard-mini-for-mac/features/safari-protection.md (16-16) The alt text for the first image says 'General tab' but this section is about Safari protection. Consider updating the alt text to better reflect the image content.
- docs/adguard-mini-for-mac/features/features.md (6-30) There's an inconsistency in the link formats. Some links use relative paths without a leading slash (lines 6 and 10), while others use paths with a leading slash (lines 14, 18, 22, 26, and 30). For consistency and to avoid potential navigation issues, all links should follow the same format.
💡 To request another review, post a new comment with "/windsurf-review".
|
|
||
| Here's an example of a tricky case — a cookie popup that resists filtering. Find it in the page code, then open *User rules* and create a rule to block it: | ||
|
|
||
| <iframe class="youtube-video" src="https://cdn.adtidy.org/content/blog/rule.mp4" title="Video player" frameborder="0" allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture" allowfullscreen></iframe> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The iframe tag is using escaped HTML entities (\u003c instead of <). This won't render properly in Markdown. Consider replacing these with actual angle brackets:
| <iframe class="youtube-video" src="https://cdn.adtidy.org/content/blog/rule.mp4" title="Video player" frameborder="0" allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture" allowfullscreen></iframe> | |
| <iframe class="youtube-video" src="https://cdn.adtidy.org/content/blog/rule.mp4" title="Video player" frameborder="0" allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture" allowfullscreen></iframe> |
|
Preview was deployed to: https://pull-request-798.kb-adg.pages.dev/ |
|
Preview was deployed to: https://pull-request-798.kb-adg.pages.dev/ |
|
Preview was deployed to: https://pull-request-798.kb-adg.pages.dev/ |
|
Preview was deployed to: https://pull-request-798.kb-adg.pages.dev/ |
|
Preview was deployed to: https://pull-request-798.kb-adg.pages.dev/ |
|
Preview was deployed to: https://pull-request-798.kb-adg.pages.dev/ |
|
Preview was deployed to: https://pull-request-798.kb-adg.pages.dev/ |
1 similar comment
|
Preview was deployed to: https://pull-request-798.kb-adg.pages.dev/ |
|
/windsurf-review |
Co-authored-by: windsurf-bot[bot] <189301087+windsurf-bot[bot]@users.noreply.github.com>
|
Preview was deployed to: https://pull-request-798.kb-adg.pages.dev/ |
Co-authored-by: windsurf-bot[bot] <189301087+windsurf-bot[bot]@users.noreply.github.com>
|
Preview was deployed to: https://pull-request-798.kb-adg.pages.dev/ |
|
Preview was deployed to: https://pull-request-798.kb-adg.pages.dev/ |
|
Preview was deployed to: https://pull-request-798.kb-adg.pages.dev/ |
|
Preview was deployed to: https://pull-request-798.kb-adg.pages.dev/ |
|
/windsurf-review |
|
Preview was deployed to: https://pull-request-798.kb-adg.pages.dev/ |
|
/windsurf-review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other comments (5)
-
docs/adguard-mini-for-mac/solving-problems/ads-not-blocked.md (8-8)
The info box is missing a period at the end of the sentence.
This article is about AdGuard Mini for Mac, which safeguards only your Safari browser. To protect your Mac entirely, [download the AdGuard app](https://agrd.io/download-kb-adblock). -
docs/adguard-mini-for-mac/installation.md (8-8)
The info box message is missing a period at the end of the sentence.
This article is about AdGuard Mini for Mac, which safeguards only your Safari browser. To protect your Mac entirely, [download the AdGuard app](https://agrd.io/download-kb-adblock). -
docs/adguard-mini-for-mac/installation.md (26-26)
For consistency with legal document references, 'EULA and Privacy policy' should be 'EULA and Privacy Policy'.
3. In the opened AdGuard Mini window, accept EULA and Privacy Policy and click *Continue*. -
docs/adguard-mini-for-mac/solving-problems/private-sonoma.md (8-8)
The info block is missing a period at the end of the sentence.
This article is about AdGuard Mini for Mac, which safeguards only your Safari browser. To protect your Mac entirely, [download the AdGuard app](https://agrd.io/download-kb-adblock). -
docs/adguard-mini-for-mac/solving-problems/ads-not-blocked.md (25-25)
There's a typo in the image markdown for the update button. The '*mobile' text should be removed from the alt text.

💡 To request another review, post a new comment with "/windsurf-review".
docs/adguard-mini-for-mac/features/settings/safari-extensions/_category_.json
Outdated
Show resolved
Hide resolved
Co-authored-by: windsurf-bot[bot] <189301087+windsurf-bot[bot]@users.noreply.github.com>
|
Preview was deployed to: https://pull-request-798.kb-adg.pages.dev/ |
1 similar comment
|
Preview was deployed to: https://pull-request-798.kb-adg.pages.dev/ |
…ithub.com/AdguardTeam/KnowledgeBase into AGM-2665-add-adguard-mini-for-mac-section
|
Preview was deployed to: https://pull-request-798.kb-adg.pages.dev/ |
|
|
||
| :::note | ||
|
|
||
| AdGuard is committed to protecting your privacy. We strictly follow our [Privacy Policy](https://adguard.com/privacy/mini-mac.html) and do not collect any private information about users. Before sending your logs to the support team, please review the file as it may contain additional information that you don’t want to share. If it contains such personal information, we recommend that you delete it first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the Privacy notice. besides, this link is not available yet. you can replace it with the link to our Privacy policy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I just did it in the same way as it was here -
| AdGuard is committed to protecting your privacy. We strictly follow our [Privacy Policy](https://adguard.com/privacy/safari.html) and do not collect any private information about users. Before sending your logs to the support team, please review the file as it may contain additional information that you don’t want to share. If it contains such personal information, we recommend that you delete it first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But maybe the link to the whole Privacy policy would be better better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
☑️
Co-authored-by: Helen <[email protected]>
|
Preview was deployed to: https://pull-request-798.kb-adg.pages.dev/ |
|
Preview was deployed to: https://pull-request-798.kb-adg.pages.dev/ |
|
Preview was deployed to: https://pull-request-798.kb-adg.pages.dev/ |
|
Preview was deployed to: https://pull-request-798.kb-adg.pages.dev/ |
1 similar comment
|
Preview was deployed to: https://pull-request-798.kb-adg.pages.dev/ |
Add AdGuard Mini for Mac section: updated screenshots and instructions