This repository was archived by the owner on Nov 26, 2025. It is now read-only.
add missing floating point literals #246
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vexu
reviewed
Nov 25, 2025
src/MacroTranslator.zig
Outdated
Comment on lines
359
to
360
| // Zig doesn't support BFloat16, so the best thing we can do is convert it to u16, | ||
| // so that the value is bit-to-bit identic between the emitted Zig and original C code. |
Member
There was a problem hiding this comment.
Unless you have a specific use case I'd like to avoid adding workarounds for types that aren't supported by Zig yet.
Author
There was a problem hiding this comment.
My use case is that I import a header file that contains such constant. How should translate-c handle that ?
Member
There was a problem hiding this comment.
Letting it go to that else branch would turn those macros into @compileErrors.
Author
There was a problem hiding this comment.
Done, I also upgraded the PR description.
gwenzek
force-pushed
the
gw/fix_float_lit
branch
from
0535ea9 to
64a596c
Compare
gwenzek
force-pushed
the
gw/fix_float_lit
branch
from
f41e45a to
92fd6d8
Compare
Vexu
approved these changes
Nov 25, 2025
Vexu
reviewed
Nov 26, 2025
| .None, .F32x, .F64 => "f64", | ||
| .L => "c_longdouble", | ||
| .W => "f80", | ||
| .W, .F64x => "f80", |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the floating points literals that weren't handled: