Bump listen to 3.7.1 #404
Open
Bump listen to 3.7.1 #404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frederick888
approved these changes
Nov 2, 2022
Member
Frederick888
left a comment
Frederick888
left a comment
There was a problem hiding this comment.
LGTM.
Probably has something to do with guard/listen#479? Anyway the Listen.to() API seems compatible and 3.7.1 requires Ruby >= 2.4.0, which is well below our requirement as well.
Still would appreciate it if you can test it out before merging 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✌️
/cc @zendesk/vegemite
Description
It has been reported that bumping listen to 3.7.1 should fix this issue: #364.
Compare diff: guard/listen@v2.10.1...v3.7.1
Tasks
References
Risks
High. Might break
zat serverandzat theme previewfunctionality; anything that live reloads from the file system in order to serve an object to a target account. However, it should be easy enough to check that the functionality still works after this gem bump.