Support representation mimetype #44
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Sorry this hasn't been looked at. Do you mind checking if go 1.10.3 has a fix for the serialisation issue? And then fixing the merge conflict currently present? |
* master: Make a separate method for creating Adaptation Sets with IDs (zencoder#46) Fix UUID splitting # Conflicts: # mpd/mpd.go
Author
|
@stuarthicks The unmarshal function is still needed, no movement on the |
Contributor
|
An Unmarshal function has been implemented in #53, so I'm going to close this PR (sorry!). Bugs against that unmarshal function should probably go in a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking at why mimeTypes on the Representation node were being lost after a load and save (fixed by #42) I have also tackled the ContentProtection node being lost.
Not currently using any reflection, which might clean up a few lines, but I think this is reasonably clear. Not sure how important the references are between the Representation and the AdaptationSet are but I have set them.
Edit: If the next go release fixes the serialization, then potentially some of this work is not needed.