This repository was archived by the owner on Oct 11, 2022. It is now read-only.
remove styles and links inside inline code block #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewfan
force-pushed
the
remove-styles-before-code
branch
from
a49be6d to
aa7a23d
Compare
mxstbr
reviewed
Jun 26, 2018
| // do not modify the text if it is inside code style | ||
| const hasCodeStyle = currentInlineStyle.find(style => style === "CODE"); | ||
| if (hasCodeStyle) { | ||
| return editorState; |
There was a problem hiding this comment.
I see where you were going with this, but it might be less edge casey to filter all the text that's styled as inline code so it doesn't apply to the other inline style calculations maybe? Thoughts?
There was a problem hiding this comment.
I.e. instead of just ignoring this text that should be italic (which I think would happen rn?)
this is `some _code` and some more _text_
we could just remove the inline code bit and everything before it and pretend that the text is
and some more _text_
Does that make sense or am I way overcomplicating things?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes for #96