This repository was archived by the owner on Oct 11, 2022. It is now read-only.
Fixing blockChange selection and update react and react-dom #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelgmcd
reviewed
Apr 9, 2018
| "react-addons-pure-render-mixin": "^15.4.1", | ||
| "react-addons-test-utils": "^15.4.1", | ||
| "react-dom": "^15.4.1", | ||
| "react-dom": "16.2.0", |
There was a problem hiding this comment.
Any reason not to keep these as caret versions?
mxstbr
approved these changes
Apr 9, 2018
mxstbr
left a comment
mxstbr
left a comment
There was a problem hiding this comment.
LGTM, mind submitting a follow-up PR that updates the peerDeps to include v16?
Author
|
ugh @mxstbr I totally made that change and then didn't push it 🤦♂️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #41