This repository was archived by the owner on Oct 11, 2022. It is now read-only.
Do not convert block type if current block type is not simple #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @juliankrispel |
| if (matchArr) { | ||
| return changeCurrentBlockType( | ||
| editorState, | ||
| CHECKABLE_LIST_ITEM, |
There was a problem hiding this comment.
good catch! I suppose the existing tests broke without this?
|
looks solid to me! |
|
well done @michaelgmcd 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First off, love the plugin and the amount of work put into this fork.
When using this in my own project, I found it odd that shortcuts still apply if the block type is already a styled one. For example, typing "- " inserts a list item and then if I type "# ", the list item is removed and replaced with a header.
Note that I'm pretty new to working with Draft, so I'd appreciate an extra close look at this.