-
-
Notifications
You must be signed in to change notification settings - Fork 233
Support Testcontainers 4.8.0 #1370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates WireMock.Net.Testcontainers to support Testcontainers 4.8.0, which introduced breaking API changes. The main issue was a MissingMethodException caused by changes to the ContainerConfiguration constructor signature in Testcontainers 4.8.0.
Key Changes:
- Updated Testcontainers package dependency from 4.7.0 to 4.8.0
- Added
uidandgidparameters to theCopyAsyncmethod to match the new base class signature
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| WireMock.Net.Testcontainers.csproj | Updated Testcontainers package reference to version 4.8.0 |
| WireMockContainer.cs | Added uid and gid parameters to CopyAsync method override to match new base class signature |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Make WireMock.Net.Testcontainers compatible with Testcontainers 4.8.0.
Testcontainers 4.8.0 is not binary compatible with 4.7.0.
Ctor of WireMockConfiguration breaks with a MissingMethodException:
References
testcontainers/testcontainers-dotnet@3b4f418#diff-42f9d6914c9475812b1c918ce9604fc2db0344b779868718675ea7850510b578
testcontainers/testcontainers-dotnet@c27a94b#diff-cfb5e3427ad9917120dc63419d9b834390f507ddfeb00dceb2fc1bd6f8d503a5
Submitter checklist
#help-contributingor a project-specific channel like#wiremock-java